Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Thu, 15 Jan 2026 10:50:00 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>
Cc: japin <japinli@hotmail.com>, "Andres Freund" <andres@anarazel.de>,
 pgsql-hackers@lists.postgresql.org, "Chao Li" <li.evan.chao@gmail.com>
Message-Id: <603d4e3e-8aa1-485f-8f0c-3f48822fbf9c@app.fastmail.com>
In-Reply-To: <202512090935.k3xrtr44hxkn@alvherre.pgsql>
References: <202512090935.k3xrtr44hxkn@alvherre.pgsql>
Subject: Re: log_min_messages per backend type
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/603d4e3e-8aa1-485f-8f0c-3f48822fbf9c%40app.fastmail.com>
Precedence: bulk

On Tue, Dec 9, 2025, at 1:30 PM, Alvaro Herrera wrote:
> BTW another thing I realized while looking this over, is that we quite
> uselessly transform the integer backend type to a string, pass it as a
> string using the --forkchild= argument to the child process, then parse
> the string back to an int to use as an array index.  It would be much
> easier to just use the integer value everywhere, as the attached shows.
>

It is a good simplification. There is just one oversight.

+   child_type = (BackendType) atoi(child_kind);
+   if (child_type <= B_INVALID || child_type > BACKEND_NUM_TYPES)
        elog(ERROR, "unknown child kind %s", child_kind);

It should be BACKEND_NUM_TYPES - 1.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/