From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Michael Paquier <michael@paquier.xyz>,
        Jacob Champion <pchampion@vmware.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <202106301439.dji3ms64lxlj@alvherre.pgsql>
References: <202106301439.dji3ms64lxlj@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 30 Jun 2021 10:39:29 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <604517.1625064175.1@sss.pgh.pa.us>
Date: Wed, 30 Jun 2021 10:42:55 -0400
Message-ID: <604518.1625064175@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/604518.1625064175%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Jun-30, Tom Lane wrote:
>> You mentioned __gcov_exit, but I'm not sure if we need an
>> exception for that.  I see it referenced by the individual .o
>> files, but the completed .so has no such reference, so at least
>> on RHEL8 it's apparently satisfied during .so linkage.  Do you
>> see something different?

> Well, not really.  I saw it but only after I removed -fprofile-arcs from
> Makefile.shlib's link line; but per my other email, that doesn't really
> work.
> Everything seems to work well for me after removing abort from that grep.

OK, thanks, will push a fix momentarily.

			regards, tom lane