Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1keByJ-0007vz-4X
	for pgsql-hackers@arkaria.postgresql.org; Sun, 15 Nov 2020 06:57:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1keBpw-0002f7-0Q
	for pgsql-hackers@arkaria.postgresql.org; Sun, 15 Nov 2020 06:48:32 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1keBpv-0002ez-Pv
	for pgsql-hackers@lists.postgresql.org; Sun, 15 Nov 2020 06:48:31 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1keBps-0000X6-GF
	for pgsql-hackers@postgresql.org; Sun, 15 Nov 2020 06:48:31 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0AF6mK8e605974;
	Sun, 15 Nov 2020 01:48:22 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Refactor pg_rewind code and make it work against a standby
In-reply-to: <95c2ad04-eb6b-7c2e-b751-c65acccd81df@iki.fi>
References: <0c5b3783-af52-3ee5-f8fa-6e794061f70d@iki.fi>
 <20200820.173224.2258034742176021277.horikyota.ntt@gmail.com>
 <f155aab5-1323-8d0c-9e3b-32703124bf00@iki.fi>
 <20200918.164150.1688011206252014871.horikyota.ntt@gmail.com>
 <CAE-ML+-uLy_DiS4VSkbsjMEY9ZBob5LqBXPc31_dQ-EsSesgEw@mail.gmail.com>
 <4744063e-1a60-1b24-e1b7-7ace5e65f0d2@iki.fi>
 <CAE-ML+9NG=HnLq8P_sHM=9UFUPnWbQDSRnmZrMPXONERVJS+zQ@mail.gmail.com>
 <da768d3a-dddc-fd3f-4b64-e951a1926bfa@iki.fi>
 <95c2ad04-eb6b-7c2e-b751-c65acccd81df@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Thu, 12 Nov 2020 14:58:02 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <605972.1605422900.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 15 Nov 2020 01:48:20 -0500
Message-ID: <605973.1605422900@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Not sure if you noticed, but piculet has twice failed the
007_standby_source.pl test that was added by 9c4f5192f:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dpiculet&dt=3D202=
0-11-15%2006%3A00%3A11
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dpiculet&dt=3D202=
0-11-13%2011%3A20%3A10

and francolin failed once:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dfrancolin&dt=3D2=
020-11-12%2018%3A57%3A33

These failures look the same:

#   Failed test 'table content after rewind and insert: query result match=
es'
#   at t/007_standby_source.pl line 160.
#          got: 'in A
# in A, before promotion
# in A, after C was promoted
# '
#     expected: 'in A
# in A, before promotion
# in A, after C was promoted
# in A, after rewind
# '
# Looks like you failed 1 test of 3.
[11:27:01] t/007_standby_source.pl ... =

Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests =


Now, I'm not sure what to make of that, but I can't help noticing that
piculet uses --disable-atomics while francolin uses --disable-spinlocks.
That leads the mind towards some kind of low-level synchronization
bug ...

			regards, tom lane