Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u2FPc-00FFMe-0c for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Apr 2025 20:19:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u2FPZ-00EyuK-35 for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Apr 2025 20:19:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u2FPY-00EyuA-KI for pgsql-hackers@lists.postgresql.org; Tue, 08 Apr 2025 20:19:09 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u2FPW-003k5D-1d for pgsql-hackers@postgresql.org; Tue, 08 Apr 2025 20:19:07 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-223fd89d036so73295365ad.1 for ; Tue, 08 Apr 2025 13:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1744143545; x=1744748345; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IOrqMej9XqdYnIF8ZNIiEEwA3ryyRrlAfm4i/XhGZGs=; b=C04cylbAO998RmOwDT7iXtYIDxoS/rmcK8hmyUNC/LuBMgUE1IxmBP90d6xUSd2HOm tvcaGki8XsPgbsaEWl0yQ42emu8Uv9XwcTg72I7wNpLav3pHKMcrtxLNafmLrSaEBcSV IOaItD5Gf0n7el/vl7nuU9Csa6ImQ9fAkTZ9AZWUFnxDH8NStSCFTJqm78PrKYb4djkG Rgu8juoe6lc6lcOztJOie5t8Bl6j2CzltpLelHao3nVOndDT4Qkz9sLUIzwtO8xJu0FP uCXonq2QY5EvXp+vNQ+iXvU3s2/pY7HMjRoPBwI+srx9CwIl/4P3kFL2WWpx/l4pm2hB 61Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744143545; x=1744748345; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IOrqMej9XqdYnIF8ZNIiEEwA3ryyRrlAfm4i/XhGZGs=; b=pfp4dY1BcT6wdbcY3q1cpkLqMt6g5//j9iIucWsM40cWS5tPlmfPWcndca8qmtgkFn TpPkfs123u0JuTSr1yy976P3nmlXKYq6RWntSE9LpD7UH5Pa5fLBq3zbMd20+ayzRTuT 2iAACwFfuzh0S9lIXxdX/qlyGc6MVLIkyKFnHXT7tc7wbsBYAms4VbAFtFWoFK335sPj o6EC7Fs7AFP5eIxMj9du76HOLyGzDshymX2iemNbJSdc7abCTi2zLlAr738CQLOL4irz 3jx5nEnHyVsSTt0xjuRGQKANEVJi+kNvirsEGfnJc5PmSqm64fl9AFPdfVk7aKH5xP+d Pomg== X-Forwarded-Encrypted: i=1; AJvYcCWAAPZUGeLeYlUWyYkP4/4WvyGskIZ0/iTkEnUa4fHz7kuCnxLPySFWrYVmBF2GcYhqp/TwMtS7ZSHJ/VyR@postgresql.org X-Gm-Message-State: AOJu0Yz1U5X1dH/dChjGHIwbQ3MB/+b+1gMUhE9IMg/Y4nddJwDpfVun iUw19SSXYGXsCmtW0MFPlcr5U0jNT1enbeHXLHTLwtXj2l6fA+UKh1jyPQ9NTw== X-Gm-Gg: ASbGncswYwdLWI/iPO5sEv4Ru3P5ay0UJQSXZIoeChkkg64REhLgxWe3JlZQkLXPkXw E03jGoroycKYxJUirqJPCsTtW7SE2WZev9/lCrwx8No0lJVrBtddKZx5vi0o7T0ODiNnMoqQt+w kAFINrvJo8E9K+MPgztw1l0fUEJ+vg1qLZVoYdxO0pr4ndivtqASwsiCM7QyfpgQ7HVO8PkBqAF u5okp0mfhQiLlFsKe7e7EEdd2yrgZoVslQNw/Vb9pUbs1bqx6mtai66pfMXY6F/1lFAZqQptUSt HHTkQjh2+8l+v7tQY4o6bzQRAVzoqs+T7YLXLZFeTdKI+0g9LMUQ/ZuhDdCEzZQgTvKs+NhZlaz Z9Fx5iSQazhRpMQ== X-Google-Smtp-Source: AGHT+IGqv5EEpAEEejdBUZnwMpZQNoaoaGPswdLpDMRTYoowFUCZEXMlr66k3APP13xG24N9lNdMeQ== X-Received: by 2002:a17:902:ce04:b0:223:5de7:6c81 with SMTP id d9443c01a7336-22ac3f9a90amr969155ad.27.1744143545067; Tue, 08 Apr 2025 13:19:05 -0700 (PDT) Received: from ?IPv6:2601:642:4c01:6dcc:9ca1:97e4:f356:e280? ([2601:642:4c01:6dcc:9ca1:97e4:f356:e280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22978776601sm104901935ad.237.2025.04.08.13.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 13:19:04 -0700 (PDT) Message-ID: <606b345bcbcb229515ab155e37e13de9333f2c09.camel@j-davis.com> Subject: Re: [18] CREATE SUBSCRIPTION ... SERVER From: Jeff Davis To: Shlok Kyal Cc: Ashutosh Bapat , Bharath Rupireddy , Joe Conway , pgsql-hackers@postgresql.org, vignesh C Date: Tue, 08 Apr 2025 13:19:03 -0700 In-Reply-To: References: <149ff9264db27cdf724b65709fbbaee4bf316835.camel@j-davis.com> <830a2bc6cbbb2e6e01c6c0d9f31f320822e10603.camel@j-davis.com> <433d0845248e86c0317d9d396926182cfe157340.camel@j-davis.com> <05ae37abb207cd6bf6b126780024692d91402b0b.camel@j-davis.com> <93392ffa941ab0d436e19e0ab5d04d0e42c02d3f.camel@j-davis.com> <26be917cb07b6aa3ef5dd15f6b59d1b375ece6e8.camel@j-davis.com> <55201bd916e748acfc754c8f95880dae8e4e5ed0.camel@j-davis.com> <2a89b14a2b1622bffb8b137ca1f9ab7866f2d2b9.camel@j-davis.com> <61831790a0a937038f78ce09f8dd4cef7de7456a.camel@j-davis.com> <0910b47040406c1d24ec0150dafb5bae6b910ed7.camel@j-davis.com> <7338f22c4534322a08ab6ce9f879e2e308eb5e5d.camel@j-davis.com> <34fd5885b8245d1014f4426ea22af61229d42e3e.camel@j-davis.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2025-04-02 at 17:58 +0530, Shlok Kyal wrote: > I reviewed the patch and I have a comment: Thank you and vignesh for the feedback. This patch didn't quite make it for v18, but I will address it for the next CF. Regards, Jeff Davis