Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wP0f0-000LQw-2r for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2026 16:17:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wP0ey-002nPl-30 for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2026 16:17:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wP0ey-002nPd-25 for pgsql-hackers@lists.postgresql.org; Mon, 18 May 2026 16:17:41 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wP0ex-00000000DHi-2zKn for pgsql-hackers@lists.postgresql.org; Mon, 18 May 2026 16:17:41 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id A39995CB74F for ; Mon, 18 May 2026 18:17:38 +0200 (CEST) Received: from s979.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 936815CB965; Mon, 18 May 2026 18:17:38 +0200 (CEST) Received: from localhost (unknown [172.22.191.5]) by s979.loopia.se (Postfix) with ESMTP id 908C910BC44D; Mon, 18 May 2026 18:17:38 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s474.loopia.se (amavis); dkim=pass (2048-bit key) header.d=yesql.se Received: from s981.loopia.se ([172.22.191.5]) by localhost (s474.loopia.se [172.22.190.14]) (amavis, port 10024) with LMTP id pROEG0Iik6XB; Mon, 18 May 2026 18:17:38 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 69.196.93.195 Received: from smtpclient.apple (unknown [69.196.93.195]) (Authenticated sender: daniel@yesql.se) by s981.loopia.se (Postfix) with ESMTPSA id F302322B1760; Mon, 18 May 2026 18:17:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1779121058; bh=lSESkHyZqLPqCHFGlKWgpOrsweFCmqUQFlTVr6Vmk84=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=l9EDZWH37/T+qyeTZd1bpNgUxyqJD/+1Ko5HqaLXpzqPBtI5CQpb+R1MQ/rOpqQHM kRBNYsTB9zTDFhE3J0XJuE6ah+Rh7f5kz67CHT3/XWflPzQQH3Dj0qKuy3HOkfU/mo KFP3bbksbQClGbEJvKzDnGMUzvqd3tF4XhOaBsvMYwUWRKEyzwTGjupPCMaZsOqmP/ UUT4MJu+46k2mymECTC/cyAKTA9KIDKrr2opSMZVS224qgPKxHydkIuyArxxaZ5DUh IgLWlBLieCULyZhbyA7Q0uNt5jcSjLeDENACA+0mhYE+6MUSdGYw2fR1Lm431qxaFy MkCNfTeKY6InQ== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.12\)) Subject: Re: Fix typo 586/686 in atomics/arch-x86.h From: Daniel Gustafsson In-Reply-To: Date: Mon, 18 May 2026 09:17:22 -0700 Cc: Andres Freund , Tomas Vondra , Jakub Wartak , PostgreSQL Hackers , Thomas Munro Content-Transfer-Encoding: quoted-printable Message-Id: <60D08F6B-6B4E-43A2-A12C-548FC6D2BA1D@yesql.se> References: <4FD9BE34-FDD1-4D4D-839F-B9D2596D6084@yesql.se> <7D3A6A2C-EA71-4E47-83F0-3A4E6C6DEF7B@yesql.se> To: Nathan Bossart X-Mailer: Apple Mail (2.3776.700.51.11.12) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 8 May 2026, at 07:31, Nathan Bossart = wrote: >=20 > On Fri, May 08, 2026 at 09:32:16AM +0200, Daniel Gustafsson wrote: >> On 7 May 2026, at 23:46, Nathan Bossart = wrote: >>> To be clear, I'm +1 on removing any 32-bit code in this file. But = the >>> 64-bit stuff should probably be fixed. >>=20 >> Agreed. Reading over the threads you linked it seems the way forward = is to >> apply the patch posted here, and then fix arch detection so that = atomics.h >> picks up the right code for x86-64. >=20 > +1 Done. -- Daniel Gustafsson