public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tomas Vondra <[email protected]>
To: Robert Haas <[email protected]>
To: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample
Date: Fri, 11 Feb 2022 20:52:46 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobqyX6s2VQ0=HGZc4xW+tOusPa0FLfSevH_PA2Kum34BA@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CA+TgmoYx596-mqUP=xf0DdQ97UERxXfzhR0Otpa411sGV1vKow@mail.gmail.com>
<[email protected]>
<CA+TgmobqyX6s2VQ0=HGZc4xW+tOusPa0FLfSevH_PA2Kum34BA@mail.gmail.com>
On 2/11/22 19:13, Robert Haas wrote:
> On Fri, Feb 11, 2022 at 1:06 PM Tom Lane <[email protected]> wrote:
>> While I'm not opposed to moving those goalposts at some point,
>> I think pushing them all the way up to 9.5 for this one easily-fixed
>> problem is not very reasonable.
>>
>> Given other recent discussion, an argument could be made for moving
>> the cutoff to 9.2, on the grounds that it's too hard to test against
>> anything older. But that still leaves us needing a version check
>> if we want to use TABLESAMPLE.
>
> OK, thanks.
>
Yeah, I think checking server_version is fairly simple. Which is mostly
why I haven't done anything about that in the submitted patch, because
the other issues (what fraction to sample) seemed more important.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox