Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w97l6-001CZv-1W for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Apr 2026 20:38:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w97l3-000JuT-2W for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Apr 2026 20:38:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w97l3-000JuL-1F for pgsql-hackers@lists.postgresql.org; Sat, 04 Apr 2026 20:38:17 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w97l1-00000000cOb-1oOL for pgsql-hackers@lists.postgresql.org; Sat, 04 Apr 2026 20:38:17 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id AD5CE5A2153 for ; Sat, 04 Apr 2026 22:38:14 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 94F7D5A31BC; Sat, 04 Apr 2026 22:38:14 +0200 (CEST) Received: from localhost (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id 92D772C8BA86; Sat, 04 Apr 2026 22:38:14 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s473.loopia.se (amavis); dkim=pass (2048-bit key) header.d=yesql.se Received: from s979.loopia.se ([172.22.191.5]) by localhost (s473.loopia.se [172.22.190.13]) (amavis, port 10024) with LMTP id 6_pIxsRykI4x; Sat, 4 Apr 2026 22:38:14 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.236 Received: from smtpclient.apple (customer-89-255-232-236.stosn.net [89.255.232.236]) (Authenticated sender: daniel@yesql.se) by s979.loopia.se (Postfix) with ESMTPSA id 026E110BC3E2; Sat, 04 Apr 2026 22:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1775335094; bh=k/rms++ydiKKpqNUVWatTbjAWwP5YM7+XJFlON1C3p8=; h=From:Subject:Date:Cc:To; b=C4B2oq95SHHVqKZLpR6PxqfC8ONCbK0X6wqBCfec4lAU1pQHa8jufuiwCGpCO4dEo ybVIqCFW67Pklci5vXCMbykOifEBonTW/XWe6v0edsdzvZqWTMdaABjKPdP9b1Kfc0 YmVveNvVZ6r2AaQDBeAeOTfyr1bxGsx4S9Fvuvf4HKwZhz/ug6m5QUo9xQp2g27Lx8 yNTbNmuaoGlfDrSn9M2ppqPjOpRoBPMutRsn/RdXm/a7wG1kmjSQHruOMiJY2iSnag sSxyRzaS52brOMmsCZpyciKsshHs0zRp9M01D+y2UOolHh0HdFm0LHVIVGcmMrOvgW thOvRR5qQxOcA== From: Daniel Gustafsson Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\)) Subject: Unused injection point in hash agg code Message-Id: <610A36DB-F413-41BF-9EB5-220D0CB09767@yesql.se> Date: Sat, 4 Apr 2026 22:38:03 +0200 Cc: Jeff Davis To: PostgreSQL-development X-Mailer: Apple Mail (2.3776.700.51.11.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Commit 38172d1856b3 introduced several injection points for hash = aggregation, among them hash-aggregate-oversize-table which is never attached to = anywhere it seems? Should it be removed, or implemented in = injection_points/sql/hashagg.sql? -- Daniel Gustafsson