Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9qBk-0005cY-UX for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Jul 2022 15:46:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qBj-0005Vv-Qt for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Jul 2022 15:46:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9qBi-0005NP-Sl for pgsql-hackers@lists.postgresql.org; Fri, 08 Jul 2022 15:46:39 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9qBd-0005MQ-JW for pgsql-hackers@postgresql.org; Fri, 08 Jul 2022 15:46:38 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3E02C5C00FC; Fri, 8 Jul 2022 11:46:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 08 Jul 2022 11:46:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657295191; x= 1657381591; bh=hTq+D7gayZlfLPba+2eNWaz7X/AN6xCAxRodSuXajiI=; b=d /N0WW+35J8Ni7b0bZVF0pyZGmJE1sL+qlaZd/7vHyVtrddx/wm+9FYCh/N+T2DF1 ImPjjWzAl7WnNOygRdISHKNefK9hZ1Su6aRNB3IE+QNKr8P6CPPZFfhn4IVRyCHp r/mqFnwNV1uk7hiKJHSmnbzwo1217RMXH1Fc2+SGzTkl6qiw+2zU5VmOCCa4Rz+3 Qq3CqB1INbUbyHzcrHxshO03+6mjLM46W7JTYzHK/VK2nBH/kMMDKTOXV9BV4SNm L+u+4BKqDCj/oucRLmIQ7GoNpMpwVPAbXaPrV5s1tSsumHRL+8KkQlrMmavIPVYT Yb4foLQhXL9H7oWp6/5qg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttdefjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgv rhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomheqnecuggftrf grthhtvghrnhepheelffeggedujeetiefhleetuddvieffhfffvdejvdffgeejkeduledu heduieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epphgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 11:46:29 -0400 (EDT) Message-ID: <611d2e93-6330-47fa-0970-72316aed50f2@enterprisedb.com> Date: Fri, 8 Jul 2022 17:46:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: automatically generating node support functions Content-Language: en-US To: Tom Lane Cc: David Rowley , pgsql-hackers References: <50fedc80-4104-bdc8-d777-04f030fc550f@dunslane.net> <7848b872-7a10-67b2-b55f-7c9c475ae863@enterprisedb.com> <40a2e977-98ba-0c01-af6c-9dfb39e864ba@enterprisedb.com> <812ea8eb-6827-ba32-6ec0-6714f7ffa5dd@enterprisedb.com> <2905876.1644858587@sss.pgh.pa.us> <968928d9-a526-a1b5-dc36-0355632a843e@enterprisedb.com> <1294462.1656875649@sss.pgh.pa.us> <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com> <1593978.1656953960@sss.pgh.pa.us> <2592455.1657140387@sss.pgh.pa.us> <3302658.1657288366@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: <3302658.1657288366@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 08.07.22 15:52, Tom Lane wrote: > I'll re-read the patch today, but how open are you to putting the > struct attributes at the top? I'm willing to do the legwork. I agree near the top would be preferable. I think it would even be feasible to parse the whole thing if pgindent split it across lines. I sort of tried to maintain the consistency with C/C++ attributes like __attribute__ and [[attribute]], hoping that that would confuse other tooling the least. Feel free to experiment further.