Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIOip-00062Q-BQ for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jan 2023 06:48:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIOin-0003E3-CS for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Jan 2023 06:48:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIOim-0003Du-Tk for pgsql-hackers@lists.postgresql.org; Thu, 19 Jan 2023 06:48:25 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIOik-00057S-Pa for pgsql-hackers@postgresql.org; Thu, 19 Jan 2023 06:48:24 +0000 Received: from [192.168.28.53] (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 0A04121C7761; Thu, 19 Jan 2023 09:48:20 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1674110901; bh=LNpCRr4M/le1SSP6TSSPvYXXKyvW0zfmfhJrAkhQraw=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=jtDb2VGyToX+3xpk4A5SQdmc2FI9lq5pF0K5WMaE/gDXCU53WMimj4Awj3QoOjK8C 8QDuLff2kx6v6tS8tcaeBO191SX4msSlL+YAQzumWPaCz6QfXIZsiLuTT3RgSQis9A WDowJwsov1KeNiS5OIe2ZfsizYSd43Yeu+ltdHrU= Message-ID: <612be20c-da68-7a6c-9f2b-297edc47d459@postgrespro.ru> Date: Thu, 19 Jan 2023 11:48:20 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH] random_normal function Content-Language: en-US To: Tom Lane Cc: Dean Rasheed , Fabien COELHO , Michael Paquier , Justin Pryzby , pgsql-hackers@postgresql.org, Paul Ramsey References: <20221208224623.GQ27893@telsasoft.com> <20221231035804.GJ1153@telsasoft.com> <1682143.1672713508@sss.pgh.pa.us> <1776287.1672764097@sss.pgh.pa.us> <3983784.1673223640@sss.pgh.pa.us> <3996998.1673230641@sss.pgh.pa.us> <4173840.1673290336@sss.pgh.pa.us> <72017e35-9b16-9223-d785-3e5a452f186a@postgrespro.ru> <4000009.1674108095@sss.pgh.pa.us> From: Andrey Lepikhov Organization: Postgres Professional In-Reply-To: <4000009.1674108095@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 1/19/23 11:01, Tom Lane wrote: > Andrey Lepikhov writes: >> On 1/9/23 23:52, Tom Lane wrote: >>> BTW, if this does bring the probability of failure down to the >>> one-in-a-billion range, I think we could also nuke the whole >>> "ignore:" business, simplifying pg_regress and allowing the >>> random test to be run in parallel with others. > >> We have used the pg_sleep() function to interrupt a query at certain >> execution phase. But on some platforms, especially in containers, the >> query can vary execution time in so widely that the pg_sleep() timeout, >> required to get rid of dependency on a query execution time, has become >> unacceptable. So, the "ignore" option was the best choice. > > But does such a test have any actual value? If your test infrastructure > ignores the result, what makes you think you'd notice if the test did > indeed detect a problem? Yes, it is good to catch SEGFAULTs and assertions which may be frequent because of a logic complexity in the case of timeouts. > > I think "ignore:" was a kluge we put in twenty-plus years ago when our > testing standards were a lot lower, and it's way past time we got > rid of it. Ok, I will try to invent alternative way for deep (and stable) testing of timeouts. Thank you for the answer. -- Regards Andrey Lepikhov Postgres Professional