Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while
 a promotion is ongoing.
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: dilipbalaut@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
References: 
 <CAFiTN-vgo9VnNDq2EaPfFBzpmUt=DjwzyY8xaC9ss3Pz9Y3OMw@mail.gmail.com>
 <20210519.152529.1656496447023808157.horikyota.ntt@gmail.com>
 <25396c69-9f70-ca3e-5de3-f3a108ae2a26@oss.nttdata.com>
 <20210519.164352.1786666023204393975.horikyota.ntt@gmail.com>
 <63ad1368-18e2-8900-8443-524bdfb1bef5@oss.nttdata.com>
Message-ID: <613321d7-e629-90ac-1006-8f63b4713c8e@oss.nttdata.com>
Date: Mon, 31 May 2021 12:52:54 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <63ad1368-18e2-8900-8443-524bdfb1bef5@oss.nttdata.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/613321d7-e629-90ac-1006-8f63b4713c8e%40oss.nttdata.com>
Precedence: bulk


On 2021/05/19 19:24, Fujii Masao wrote:
> 
> 
> On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
>> +1 for adding some tests for pg_wal_replay_pause() but the test seems
>> like checking only that pg_get_wal_replay_pause_state() returns the
>> expected state value.  Don't we need to check that the recovery is
>> actually paused and that the promotion happens at expected LSN?
> 
> Sounds good. Attached is the updated version of the patch.
> I added such checks into the test.
> 
> BTW, while reading some recovery regression tests, I found that
> 013_crash_restart.pl has "use Time::HiRes qw(usleep)" but it seems
> not necessary. We can safely remove that? Patch attached.

Barring any objections, I'm thinking to commit these two patches.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION