Feedback-ID: ie0a040ee:Fastmail
Message-ID: <613c120a-5413-4fa7-a501-6590eae558f8@eisentraut.org>
Date: Thu, 14 Mar 2024 15:38:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Built-in CTYPE provider
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, Daniel Verite <daniel@manitou-mail.org>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Jeremy Schneider <schneider@ardentperf.com>, pgsql-hackers@postgresql.org
References: <6f3e94c0-f174-4380-9b69-072f8a838881@manitou-mail.org>
 <12e4f6a78403b33c303c20e44976f891d879be09.camel@j-davis.com>
 <612987b5-38fa-44c6-8b78-c0be5a177a70@eisentraut.org>
 <2692039df6b0cac20c5e488fa0209e8958c5fedb.camel@j-davis.com>
 <27bb0e52-801d-4f73-a0a4-02cfdd4a9ada@eisentraut.org>
 <4a69d067374d2f6bfb66f5bfb2ab9a020493d49f.camel@j-davis.com>
 <3bc653b5d562ae9e2838b11cb696816c328a489a.camel@j-davis.com>
 <163f4e2190cdf67f67016044e503c5004547e5a9.camel@j-davis.com>
 <6bdb98e68b2b05aa71f7f934e227738eac84ecee.camel@j-davis.com>
 <19b34a70-f5cf-4faf-88dc-917db44ed48d@eisentraut.org>
 <846a7e1fa2024918b58ff7583523a2f3de9a11b4.camel@j-davis.com>
 <3117d30aa911b408b90420f4f280fa0c3b5851be.camel@j-davis.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <3117d30aa911b408b90420f4f280fa0c3b5851be.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/613c120a-5413-4fa7-a501-6590eae558f8%40eisentraut.org>
Precedence: bulk

On 14.03.24 09:08, Jeff Davis wrote:
> 0001 (the C.UTF-8 locale) is also close. Considering that most of the
> infrastructure is already in place, that's not a large patch. You many
> have some comments about the way I'm canonicalizing and validating in
> initdb -- that could be cleaner, but it feels like I should refactor
> the surrounding code separately first.

If have tested this against the libc locale C.utf8 that was available on 
the OS, and the behavior is consistent.

I wonder if we should version the builtin locales too.  We might make a 
mistake and want to change something sometime?

Tiny comments:

* src/bin/scripts/t/020_createdb.pl

The two added tests should have different names that tells them apart
(like the new initdb tests).

* src/include/catalog/pg_collation.dat

Maybe use 'and' instead of '&' in the description.

> 0002 (inlining utf8 functions) is also ready.

Seems ok.

> For 0003 and beyond, I'd like some validation that it's what you had in
> mind.

I'll look into those later.