Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j3ar9-0007xf-9X for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Feb 2020 07:30:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j3ar6-00068i-Ci for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Feb 2020 07:30:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j3ar6-00068a-3n for pgsql-hackers@lists.postgresql.org; Mon, 17 Feb 2020 07:30:12 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3aqz-0004D9-9c for pgsql-hackers@postgresql.org; Mon, 17 Feb 2020 07:30:11 +0000 Received: from hnk.local (sp49-97-93-217.msc.spmode.ne.jp [49.97.93.217]) by oss.nttdata.com (Postfix) with ESMTPSA id AB87F6050F; Mon, 17 Feb 2020 16:30:00 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.5 at oss.nttdata.com Subject: Re: Wait event that should be reported while waiting for WAL archiving to finish To: Robert Haas Cc: Michael Paquier , "pgsql-hackers@postgresql.org" References: <20200213032804.GB1520@paquier.xyz> <949931aa-4ed4-d867-a7b5-de9c02b2292b@oss.nttdata.com> <20200213073035.GI1520@paquier.xyz> From: Fujii Masao Message-ID: <61477660-dded-2550-b101-c76a2f864806@oss.nttdata.com> Date: Mon, 17 Feb 2020 16:30:00 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------6E3B9017308FA31824222615" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------6E3B9017308FA31824222615 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2020/02/14 23:43, Robert Haas wrote: > On Thu, Feb 13, 2020 at 10:47 PM Fujii Masao > wrote: >> Fixed. Thanks for the review! > > I think it would be safer to just report the wait event during > pg_usleep(1000000L) rather than putting those calls around the whole > loop. It does not seem impossible that ereport() or > CHECK_FOR_INTERRUPTS() could do something that reports a wait event > internally. OK, so I attached the updated version of the patch. Thanks for the review! Regards, -- Fujii Masao NTT DATA CORPORATION Advanced Platform Technology Group Research and Development Headquarters --------------6E3B9017308FA31824222615 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="wait_event_wal_archive_v3.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="wait_event_wal_archive_v3.patch" ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3Nn bWwvbW9uaXRvcmluZy5zZ21sCmluZGV4IGE5ZjZlZTZlMzIuLjJmODhiNDE1MjkgMTAwNjQ0 Ci0tLSBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21s L21vbml0b3Jpbmcuc2dtbApAQCAtMTMzNSw3ICsxMzM1LDExIEBAIHBvc3RncmVzICAgMjcw OTMgIDAuMCAgMC4wICAzMDA5NiAgMjc1MiA/ICAgICAgICBTcyAgIDExOjM0ICAgMDowMCBw b3N0Z3Jlczogc2VyCiAgICAgICAgICA8ZW50cnk+V2FpdGluZyBpbiBhbiBleHRlbnNpb24u PC9lbnRyeT4KICAgICAgICAgPC9yb3c+CiAgICAgICAgIDxyb3c+Ci0gICAgICAgICA8ZW50 cnkgbW9yZXJvd3M9IjM2Ij48bGl0ZXJhbD5JUEM8L2xpdGVyYWw+PC9lbnRyeT4KKyAgICAg ICAgIDxlbnRyeSBtb3Jlcm93cz0iMzciPjxsaXRlcmFsPklQQzwvbGl0ZXJhbD48L2VudHJ5 PgorICAgICAgICAgPGVudHJ5PjxsaXRlcmFsPkJhY2t1cFdhaXRXYWxBcmNoaXZlPC9saXRl cmFsPjwvZW50cnk+CisgICAgICAgICA8ZW50cnk+V2FpdGluZyBmb3IgV0FMIGZpbGVzIHJl cXVpcmVkIGZvciB0aGUgYmFja3VwIHRvIGJlIHN1Y2Nlc3NmdWxseSBhcmNoaXZlZC48L2Vu dHJ5PgorICAgICAgICA8L3Jvdz4KKyAgICAgICAgPHJvdz4KICAgICAgICAgIDxlbnRyeT48 bGl0ZXJhbD5CZ1dvcmtlclNodXRkb3duPC9saXRlcmFsPjwvZW50cnk+CiAgICAgICAgICA8 ZW50cnk+V2FpdGluZyBmb3IgYmFja2dyb3VuZCB3b3JrZXIgdG8gc2h1dCBkb3duLjwvZW50 cnk+CiAgICAgICAgIDwvcm93PgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL3Ry YW5zYW0veGxvZy5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZy5jCmluZGV4 IDM4MTNlYWRmYjQuLmRjZTBmM2IwNDEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2FjY2Vz cy90cmFuc2FtL3hsb2cuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9n LmMKQEAgLTExMTA3LDcgKzExMTA3LDkgQEAgZG9fcGdfc3RvcF9iYWNrdXAoY2hhciAqbGFi ZWxmaWxlLCBib29sIHdhaXRmb3JhcmNoaXZlLCBUaW1lTGluZUlEICpzdG9wdGxpX3ApCiAJ CQkJcmVwb3J0ZWRfd2FpdGluZyA9IHRydWU7CiAJCQl9CiAKKwkJCXBnc3RhdF9yZXBvcnRf d2FpdF9zdGFydChXQUlUX0VWRU5UX0JBQ0tVUF9XQUlUX1dBTF9BUkNISVZFKTsKIAkJCXBn X3VzbGVlcCgxMDAwMDAwTCk7CisJCQlwZ3N0YXRfcmVwb3J0X3dhaXRfZW5kKCk7CiAKIAkJ CWlmICgrK3dhaXRzID49IHNlY29uZHNfYmVmb3JlX3dhcm5pbmcpCiAJCQl7CmRpZmYgLS1n aXQgYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3Bnc3RhdC5jIGIvc3JjL2JhY2tlbmQvcG9z dG1hc3Rlci9wZ3N0YXQuYwppbmRleCA1OWRjNGYzMWFiLi42ZTdhNTdiMWI3IDEwMDY0NAot LS0gYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3Bnc3RhdC5jCisrKyBiL3NyYy9iYWNrZW5k L3Bvc3RtYXN0ZXIvcGdzdGF0LmMKQEAgLTM3MzcsNiArMzczNyw5IEBAIHBnc3RhdF9nZXRf d2FpdF9pcGMoV2FpdEV2ZW50SVBDIHcpCiAKIAlzd2l0Y2ggKHcpCiAJeworCQljYXNlIFdB SVRfRVZFTlRfQkFDS1VQX1dBSVRfV0FMX0FSQ0hJVkU6CisJCQlldmVudF9uYW1lID0gIkJh Y2t1cFdhaXRXYWxBcmNoaXZlIjsKKwkJCWJyZWFrOwogCQljYXNlIFdBSVRfRVZFTlRfQkdX T1JLRVJfU0hVVERPV046CiAJCQlldmVudF9uYW1lID0gIkJnV29ya2VyU2h1dGRvd24iOwog CQkJYnJlYWs7CmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9wZ3N0YXQuaCBiL3NyYy9pbmNs dWRlL3Bnc3RhdC5oCmluZGV4IDNhNjVhNTE2OTYuLjIwMzEzZjFlMzIgMTAwNjQ0Ci0tLSBh L3NyYy9pbmNsdWRlL3Bnc3RhdC5oCisrKyBiL3NyYy9pbmNsdWRlL3Bnc3RhdC5oCkBAIC04 MTcsNyArODE3LDggQEAgdHlwZWRlZiBlbnVtCiAgKi8KIHR5cGVkZWYgZW51bQogewotCVdB SVRfRVZFTlRfQkdXT1JLRVJfU0hVVERPV04gPSBQR19XQUlUX0lQQywKKwlXQUlUX0VWRU5U X0JBQ0tVUF9XQUlUX1dBTF9BUkNISVZFID0gUEdfV0FJVF9JUEMsCisJV0FJVF9FVkVOVF9C R1dPUktFUl9TSFVURE9XTiwKIAlXQUlUX0VWRU5UX0JHV09SS0VSX1NUQVJUVVAsCiAJV0FJ VF9FVkVOVF9CVFJFRV9QQUdFLAogCVdBSVRfRVZFTlRfQ0xPR19HUk9VUF9VUERBVEUsCg== --------------6E3B9017308FA31824222615--