Message-ID: <616c6873-83b5-85c0-93cb-548977c39c60@enterprisedb.com>
Date: Thu, 10 Mar 2022 17:31:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.2
Subject: Re: [RFC] building postgres with meson -v7
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20220308025629.3xh2yo4sau74oafo@alap3.anarazel.de>
 <721828a7-3043-6803-a85b-da63538db3cc@enterprisedb.com>
 <20220309164420.rr5lws22asrd5mfm@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220309164420.rr5lws22asrd5mfm@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/616c6873-83b5-85c0-93cb-548977c39c60%40enterprisedb.com>
Precedence: bulk

On 09.03.22 17:44, Andres Freund wrote:
>> v6-0009-prereq-make-unicode-targets-work-in-vpath-builds.patch.gz
>>
>> Another directory issue
> I think it's a tad different, in that it's fixing something that's currently
> broken in VPATH builds.

Ok, I took another look at this.

-override CPPFLAGS := -DFRONTEND $(CPPFLAGS)
+override CPPFLAGS := -DFRONTEND 
-I$(abs_top_builddir)/src/common/unicode $(CPPFLAGS)

This could just be

-I.

-   $(PERL) generate-unicode_norm_table.pl
+   $(PERL) $< $(CURDIR)

I didn't detect a need for the additional directory argument.  (So the 
changes in generate-unicode_norm_table.pl are also apparently not 
necessary.)  Maybe this is something that will become useful later, in 
which case it should be split out from this patch.

The rest of this patch looks ok.