Message-ID: <61846051-90b9-adb6-7627-08a374473a61@joeconway.com>
Date: Wed, 23 Nov 2022 15:32:17 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: drop postmaster symlink
Content-Language: en-US
To: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?=
 <devrim@gunduz.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ece84b69-8f94-8b88-925f-64207cb3a2f0@enterprisedb.com>
 <252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com>
 <6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org>
 <3705500.1669216069@sss.pgh.pa.us>
 <20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de>
 <CA+TgmoZdJ3TOBCnoz0x0zzfOtbOR12f1PHLQP8G1U3NEycUgRw@mail.gmail.com>
From: Joe Conway <mail@joeconway.com>
In-Reply-To: 
 <CA+TgmoZdJ3TOBCnoz0x0zzfOtbOR12f1PHLQP8G1U3NEycUgRw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/61846051-90b9-adb6-7627-08a374473a61%40joeconway.com>
Precedence: bulk

On 11/23/22 15:10, Robert Haas wrote:
> On Wed, Nov 23, 2022 at 2:50 PM Andres Freund <andres@anarazel.de> wrote:
>> On 2022-11-23 10:07:49 -0500, Tom Lane wrote:
>> > Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org> writes:
>> > > ...and it helps us to find the "main" process a bit easily.
>> >
>> > Hmm, that's a nontrivial point perhaps.  It's certain that this
>> > will break some other people's start scripts too.
>>
>> OTOH, postmaster has been deprecated for ~15 years.
> 
> Yeah. Also, I don't think it's generally too hard to find the parent
> process anyway, because at least on my system, the other ones end up
> with ps display that looks like "postgres: logical replication
> launcher" or whatever. The main process doesn't set the ps status
> display, so that's the only one that shows a full path to the
> executable in the ps status, which is how I usually spot it. That has
> the advantage that it doesn't matter which name was used to launch it,
> too.

Same here

> I don't actually care very much whether we get rid of the postmaster
> symlink or not, but if we aren't going to, we should stop calling it
> deprecated. If 15 years isn't enough time to remove it, what ever will
> be? I tend to think it's fairly pointless and perhaps also a bit
> confusing, because the product is postgres not postmaster and people
> can reasonably expect the binary name to match the product name. But
> if we keep it, I don't think anything too dire will happen, either.

FWIW, the reason I took note of the postmaster symlink in the first 
place a few years ago was because selinux treats execution of programs 
from symlinks differently than from actual files.

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com