Message-ID: <618bc573-a0df-4ea9-bb71-aecff104c5f5@vondra.me>
Date: Fri, 16 Aug 2024 11:22:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Parallel CREATE INDEX for BRIN indexes
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Andres Freund <andres@anarazel.de>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAEze2Wi9nWxx2wDTHaBJi36JLQ+-JcTU0BcRh+yd8AR-9VNxTw@mail.gmail.com>
 <c990c65c-93e9-f9c3-6792-02f929ce308f@enterprisedb.com>
 <CAEze2Wi1X=+M9=k2FUAL-b0rfvVK08q-x+-+wkam+T-8tcbgrw@mail.gmail.com>
 <c49dfd75-0a40-7feb-1018-54740e9a91db@enterprisedb.com>
 <CAEze2WiMsPZg=xkvSF_jt4=69k6K7gz5B8V2wY3gCGZ+1BzCbQ@mail.gmail.com>
 <99f9ecbe-0976-8012-67b5-dbff58c7dbec@enterprisedb.com>
 <CAEze2WjmoEo9UFpsiq_1sngOnZArjUMjN8wyzcQvegLFDddYUQ@mail.gmail.com>
 <32e3f645-389d-87f9-2ce7-33d0087f47d4@enterprisedb.com>
 <ff490ffe-6cf1-7168-d27c-cf89ed12cd09@enterprisedb.com>
 <3733d042-71e1-6ae6-5fac-00c12db62db6@enterprisedb.com>
 <20240413083635.47yve2c5pp2xt5b6@awork3.anarazel.de>
 <4a9c0545-6697-47d3-bf7c-2f5d0d7a7319@enterprisedb.com>
 <1df00a66-db5a-4e66-809a-99b386a06d86@enterprisedb.com>
 <86763810-70a1-4872-8ba7-1676f788e5a2@eisentraut.org>
Content-Language: en-US
From: Tomas Vondra <tomas@vondra.me>
In-Reply-To: <86763810-70a1-4872-8ba7-1676f788e5a2@eisentraut.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/618bc573-a0df-4ea9-bb71-aecff104c5f5%40vondra.me>
Precedence: bulk

On 8/15/24 15:48, Peter Eisentraut wrote:
> On 13.04.24 23:04, Tomas Vondra wrote:
>>>> While preparing a differential code coverage report between 16 and
>>>> HEAD, one
>>>> thing that stands out is the parallel brin build code. Neither on
>>>> coverage.postgresql.org nor locally is that code reached during our
>>>> tests.
>>>>
>>>
>>> Thanks for pointing this out, it's definitely something that I need to
>>> improve (admittedly, should have been part of the patch). I'll also look
>>> into eliminating the difference between BTREE and BRIN parallel builds,
>>> mentioned in my last message in this thread.
>>>
>>
>> Here's a couple patches adding a test for the parallel CREATE INDEX with
>> BRIN. The actual test is 0003/0004 - I added the test to pageinspect,
>> because that allows cross-checking the index to one built without
>> parallelism, which I think is better than just doing CREATE INDEX
>> without properly testing it produces correct results.
> 
> These pageinspect tests added a new use of the md5() function.  We got
> rid of those in the tests for PG17.  You could write the test case with
> something like
> 
>  SELECT (CASE WHEN (mod(i,231) = 0) OR (i BETWEEN 3500 AND 4000) THEN
> NULL ELSE i END),
> -       (CASE WHEN (mod(i,233) = 0) OR (i BETWEEN 3750 AND 4250) THEN
> NULL ELSE md5(i::text) END),
> +       (CASE WHEN (mod(i,233) = 0) OR (i BETWEEN 3750 AND 4250) THEN
> NULL ELSE encode(sha256(i::text::bytea), 'hex') END),
>         (CASE WHEN (mod(i,233) = 0) OR (i BETWEEN 3850 AND 4500) THEN
> NULL ELSE (i/100) + mod(i,8) END)
> 
> But this changes the test output slightly and I'm not sure if this gives
> you the data distribution that you need for you test.  Could your check
> this please?
> 

I think this is fine. The output only changes because sha256 produces
longer values than md5, so that the summaries are longer the index gets
a page longer. AFAIK that has no impact on the test.


regards

-- 
Tomas Vondra