Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWijk-004A8A-HO for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Aug 2023 19:32:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qWijj-003lj9-2b for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Aug 2023 19:32:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWiji-003lj0-OS for pgsql-hackers@lists.postgresql.org; Thu, 17 Aug 2023 19:32:50 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWije-000gBH-UV for pgsql-hackers@lists.postgresql.org; Thu, 17 Aug 2023 19:32:49 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3C371FF806 for ; Thu, 17 Aug 2023 19:32:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------kBmPcM0iEy4ZQ98JTKcF5vMX" Message-ID: <61d629b6-d5ad-a49e-e905-b66d3ac4903a@dunslane.net> Date: Thu, 17 Aug 2023 15:32:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US From: Andrew Dunstan Subject: meson: pgxs Makefile.global differences To: PostgreSQL Hackers X-GND-Sasl: adsend@dunslane.net List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------kBmPcM0iEy4ZQ98JTKcF5vMX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I started digging into a warning I noticed on my FDW builds where Postgres is built with meson, e.g. which has this: cc1: warning: ‘-Wformat-security’ ignored without ‘-Wformat’ [-Wformat-security] I found that the pgxs Makefile.global built under meson is a bit different. On debug builds for both this is what I get on HEAD (meson) and REL_15_STABLE (autoconf), stripped of the current components:          HEAD: CFLAGS =-Wshadow=compatible-local REL_15_STABLE: CFLAGS =-Wall  -g The warning is apparently due to the missing -Wall. Shouldn't we be aiming for pretty much identical settings? cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------kBmPcM0iEy4ZQ98JTKcF5vMX Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

I started digging into a warning I noticed on my FDW builds where Postgres is built with meson, e.g. <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-08-16%2018%3A37%3A25&stg=FileTextArrayFDW-build> which has this:

cc1: warning: ‘-Wformat-security’ ignored without ‘-Wformat’ [-Wformat-security]

I found that the pgxs Makefile.global built under meson is a bit different. On debug builds for both this is what I get on HEAD (meson) and REL_15_STABLE (autoconf), stripped of the current components:

         HEAD: CFLAGS =-Wshadow=compatible-local
REL_15_STABLE: CFLAGS =-Wall  -g

The warning is apparently due to the missing -Wall.

Shouldn't we be aiming for pretty much identical settings?


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------kBmPcM0iEy4ZQ98JTKcF5vMX--