From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: jian he <jian.universality@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CheckMyDatabase some error messages in two lines.
In-reply-to: <ZmZevewQ-8n8EWr_@nathan>
References: <CACJufxHHtvaGvV-=LD4OHAG-pM-1hyirKu8iW9+AuaN_NDskfA@mail.gmail.com> <ZmZevewQ-8n8EWr_@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Sun, 09 Jun 2024 21:02:37 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <620741.1717985573.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 09 Jun 2024 22:12:53 -0400
Message-ID: <620742.1717985573@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/620742.1717985573%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Jun 10, 2024 at 08:00:00AM +0800, jian he wrote:
>> -				 errdetail("The database was initialized with LC_COLLATE \"%s\", "
>> -						   " which is not recognized by setlocale().", collate),
>> +				 errdetail("The database was initialized with LC_COLLATE \"%s\", w=
hich is not recognized by setlocale().", collate),

> Both approaches produce the same message.  With the existing code, the t=
wo
> string literals will be concatenated without newlines.  It is probably
> split into two lines to avoid a long line in the source code.

No doubt.  People have done it both ways in the past, but I think
currently there's a weak consensus in favor of using one line for
such messages even when it runs past 80 columns, mainly because
that makes it easier to grep the source code for a message text.

But: I don't see too much value in changing this particular instance,
because the line break is in a place where it would not likely cause
you to miss finding the line.  You might grep for the first part of
the string or the second part, but probably not for ", which is not".
If the line break were in the middle of a phrase, there'd be more
argument for collapsing it out.

			regards, tom lane