Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8Kad-0003un-SX for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2019 08:04:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h8Kac-0000Fx-98 for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2019 08:04:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8Kab-0000Fq-US for pgsql-hackers@lists.postgresql.org; Mon, 25 Mar 2019 08:04:14 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8KaZ-0002TZ-11 for pgsql-hackers@postgresql.org; Mon, 25 Mar 2019 08:04:12 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id F420E21D2B; Mon, 25 Mar 2019 04:04:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 25 Mar 2019 04:04:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sG84OX zLrka8Qmuuwr/TDMynnG6vXdbv1h5xzdFAdY0=; b=KvOKtt2xi9bRc7YwhpeOfB 0zgdhmynai8ZIn/EANKJ3YND0JV8m/KwCQFvxsandZZKZEiNtuCBc4LixqSvtf5S +wcjE/euxkVdIpjcDzdFqQBRO3nWWz9LZh8abBCclapg3Kq4KSpOI165qNG5sSdu FPGgdBppTI0foy0ateGpHz8lhs5CyVNNqz/6saCe2ZcHpiA76/MOGR6kToDUC4dR lHFFgM1LgTCr5Aj/a7/QrBcfW8mUIiLIWnG0LMTRCJ21+PZ+hr3jhvkjRcpWnBlJ eyN6vgH7xesMI62YCRfSQ/pjGUzOmonFqEYzFlB6UhAHUi6fXijCYWKThVol3Bmw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrjeejgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhfhokffffgggjggtsehmtderredtfeejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvdhnughquh grughrrghnthdrtghomheqnecuffhomhgrihhnpedvnhguqhhurggurhgrnhhtrdgtohhm necukfhppeelfedrvdegfedrudekkedruddvvdenucfrrghrrghmpehmrghilhhfrhhomh epphgvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhmnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from april.pezone.net (p5df3bc7a.dip0.t-ipconnect.de [93.243.188.122]) by mail.messagingengine.com (Postfix) with ESMTPA id D84D1E409D; Mon, 25 Mar 2019 04:04:07 -0400 (EDT) Subject: Re: Fix handling of unlogged tables in FOR ALL TABLES publications To: Kyotaro HORIGUCHI , Langote_Amit_f8@lab.ntt.co.jp References: <59e5a734-9e06-1035-385b-6267175819aa@lab.ntt.co.jp> <20190314.150328.172224727.horiguchi.kyotaro@lab.ntt.co.jp> <26bfa053-3fb2-ad1d-efbb-7c930b41c0fd@lab.ntt.co.jp> <20190314.162716.103433381.horiguchi.kyotaro@lab.ntt.co.jp> Cc: pgsql-hackers@postgresql.org From: Peter Eisentraut Openpgp: preference=signencrypt Autocrypt: addr=peter.eisentraut@2ndquadrant.com; prefer-encrypt=mutual; keydata= xsFNBFUUt6kBEADZd9NNTBJbHmAXXJgPGOdd6Q73l80oifIVgn2tRxP9dYkCfTlo/yLqbKTl JNqTcyM6XrJDnB2sMEUGYCewYZXl+9C4bBJWyNqcEI1ae9u71vEq/fknFLArJ+2wN+f7QuRx Q8d94ZJAiJQ5g3fNk2HVeedCQCKP5dCzU+ZLt2dbsx1PDZLjTO9gf+JswWuGFb5wY5PZVM5V hq66Xk7ZJzHuARacza2RT7J2fkMmQBY+kr7L98Perb0GhafnlhXB0PvUB+N3xpmggMfwuhTu BngS/G/r3GvemxJuFxouw8xsMqrsfdksJXA2gLXYtwRCssdPV3PO0rlD9twqDo8URfIJ5fb6 1g/MV8aTOKjg3Q8MpJPtkwJqN4o3PvbwYdedeFnOVkkYAJdu/aX1v1BeCBDu7Hy3sF52scD3 pQbyQSl9vUDpTLarASAxNbAV0NRJE8dp4vfW6AH1ccryGiFqw/czPK/iN0+MT8wsjAW6WW4w hvjm5UPA1KTwi3ZT8eT5uycuH7QpuNk7LnGGXQ6KaRALFywzkr0A0V0AvFNa+l4wstMaXaB6 dmMXyF0/hfryqyOeu1gAdq4q0/PNC2dPgb/6uoh4eMjN6A5GXcprilhz5DulmsilY21hfSoU S64ODed96pKhprsOxjZiDRsN1QM5MwB+uwVWUNfsX7fIxE0BrwARAQABzSdQZXRlciBFaXNl bnRyYXV0IDxwZXRlckBlaXNlbnRyYXV0Lm9yZz7CwXoEEwEIACQCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFAlUUuKQCGQEACgkQoZ8SQ+xBJp8llw//RbGoXnF72FZTlOFsnNyxnWbF vViPCfdAlZl1GGK9OYCvV1dp/956HuhB0wpaGQHiBmQfOPJf/jLOPjXFYm2iEChEycrBChuE j4TSYemMp5BSPILYk9Uwd16kVD/+U6fQfK6H5pOhfBvbM6asMnmpY2wQuvktxHvaGlytFw84 EzFWNZtAZfxkw28w3AhIQkKe9hJanfyDL750RcbyEr8AAHty5IErrvS7tM5vQwIeh5BF26ND CyKPRdZgOgMpcwFfROKBDpAt052CgWIpNdhBdfIKlkCs4/ILxmC3rT/Mb/qZiHcoMMwEu6k+ T7vRAFZZAk62Yrr/U8/vUGKlzRZQoo86fyojCfI0ibCIc0z8rwCVY9P40G9wD9BTCZS/z8Vh jjpBlNnIKw2hM6hbxavKndCJjFFJD08rXrTyrLF/of18xD37vNdYooP9VATB5QjOWFRrscSZ 4a89e+to3m7YVnd4xdXwGp47dYusoax84C8tg1gZrH38ol9dPmnKX6GZrXeS7tH9k8VeUpJ8 HQbRThQRWAT936QpYbLConBmOtmbLmjQOGtiXPo1oK57X/7U/WBja5vWmm2q+Yxtt+3uHGVg DdDU4CJpXo4lX0v2n3QV5EBSW9hjdF3bNfl6GFBb1pPEhqNcMDUc7zkx/2uENdAdk/BnqMgH umip7b0pVfvOwU0EVRS3qQEQAJf6p0P7D+hMYUgCPkvgrcz6OJYsAYdUMUmokfqmkKwK0oJM ew8TNGM53ocKAgQGma5f10rwbZNPlpVPNRX5hwUmwVlcwSut0oE+JfUBH7mpysWvpF05RKIy q9RCoJZrAbXS7Tig56A1QD8IcM00rERZMcCOlI1+q9m4u9AOI+0LyGGSH+VvoyDHD/Jew4R2 TmPEF8Pu7lYiNYK88Q6u0kBkc+Tz3BNlyc6fi3HxnFfp0b75HLXPSTu2SwA/0Q31wHZXwrEU BR9KgSn/qbgy8ydPc97i82fhiFE3cbGexfPrQSMYmDGi+dcQ0s+AMQwC3XyMC0JkHpYUuFkR QdlIvaIhgFUUN2Vr4xF2ADaNTNFc4DYaiPHFAgHZw+3pZWqS4uIiWgJynrEaHw4F3QWU8/JB iyEWDhNq4WBrRA0u914TCCAoFOOKMnRdl8eJrRQKM/5/lXbHFjjlI/LDKhLRFsuQsnJJ3331 RjCzpHPZG5/p5KR1RHiAXa0p/DW5lXyq21hS3kjDlleoHqOxCN/cy0Jgz7qLDq1vZoCl67Sy RAH60c2Xu4may9SVltmot0OzWVHdrfS+85FQGp9580DaeLio7YMFKy2bfEvwQJ/c9xD2QPB+ oSb3V8ueSznXBG5+dyfOsZFRPxceA0wA2rSWZSjxLdKxvyGTj9vsCjaDu13rABEBAAHCwV8E GAEIAAkFAlUUt6kCGwwACgkQoZ8SQ+xBJp+HJhAAxmSTsC5y7p9Zu+nnLpucv/h88oEx985e qWeXzQiwM3pfRZS+PdTH9TyzHK0KOgKoAiubk0vt+BrT91D9d0G5kVQaTctAErGBoMkTaZJT XVEcNphiPzysdSqvprjojMp1y7rG8AP+Xd6m0rE1LRnkRRm8HyI8vdXsuLQPITGWXDLMjaNq AOV3BUnzkgtjMuIYw7SCr+12ZOb5dEKvaG4kjC4kaJ/TLbuBhVANcXkC90yp0AOZLs/cB1Dj OAXno/RUUruJ3r27a+pFv768UAi9QWcdw58yPxreMNMLqAgsS9oTHwHfGNWcB2dJ4UW+GMLJ hTf9TjQ2f+N/sIx5XMQ9pYw6CAJMK29qPx6/ZayrPxf22EXf0D3zTwIEZgwfSkynFVwV25L7 awQq60fifdMYheSxq7GbhpsixmcD+e161cCmLIt75YDt5bQ0B1yf7EmxG8n7pGZAOM6LoNsU fkSldba5XVwh8LuN5mK0nQBELGW6Os4TDq4REggLpfcvFC215zpuo0iCGnmE/Bns4nowqUSP u4tkWL+nxW4qgv8wo8HJ52jd79EJ8iqfIBoidBfy9AIUiEUApGQzWPu6yWcI8fY0rN5D+tc+ Yw1Zt6Mm+huYJpgCRsTcfzEcahnBn521CWcWvhW1ff3KFileFMtNmnBBhMncmRKHphtTKEpN 3jI= Organization: 2ndQuadrant Message-ID: <621516ad-7adc-9136-0a9b-21bce6e893d6@2ndquadrant.com> Date: Mon, 25 Mar 2019 09:04:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190314.162716.103433381.horiguchi.kyotaro@lab.ntt.co.jp> Content-Type: multipart/mixed; boundary="------------0427DCA6ECC0F446C1E47E0A" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------0427DCA6ECC0F446C1E47E0A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit So perhaps push the check down to GetRelationPublicationActions() instead. That way we don't have to patch up two places and everything "just works" even for possible other callers. See attached patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------0427DCA6ECC0F446C1E47E0A Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="v2-0001-Fix-handling-of-unlogged-tables-in-FOR-ALL-TABLES.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="v2-0001-Fix-handling-of-unlogged-tables-in-FOR-ALL-TABLES.pa"; filename*1="tch" RnJvbSA1NTI1NWE2ZTMzOGNjYjExYjRhN2E4ZDZmMTBhZmY3YTgwNWNkNzJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogTW9uLCAyNSBNYXIgMjAxOSAwOTowMDoxNCArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggdjJdIEZpeCBoYW5kbGluZyBvZiB1bmxvZ2dlZCB0YWJsZXMgaW4gRk9SIEFM TCBUQUJMRVMKIHB1YmxpY2F0aW9ucwoKSWYgYSBGT1IgQUxMIFRBQkxFUyBwdWJsaWNhdGlv biBleGlzdHMsIHVubG9nZ2VkIHRhYmxlcyBhcmUgaWdub3JlZApmb3IgcHVibGlzaGluZyBj aGFuZ2VzLiAgQnV0IENoZWNrQ21kUmVwbGljYUlkZW50aXR5KCkgd291bGQgc3RpbGwKY2hl Y2sgaW4gdGhhdCBjYXNlIHRoYXQgc3VjaCBhIHRhYmxlIGhhcyBhIHJlcGxpY2EgaWRlbnRp dHkgc2V0IGJlZm9yZQphY2NlcHRpbmcgdXBkYXRlcy4gIFRvIGZpeCwgaGF2ZSBHZXRSZWxh dGlvblB1YmxpY2F0aW9uQWN0aW9ucygpCnJldHVybiB0aGF0IHN1Y2ggYSB0YWJsZSBwdWJs aXNoZXMgbm8gYWN0aW9ucy4KCkRpc2N1c3Npb246IGh0dHBzOi8vd3d3LnBvc3RncmVzcWwu b3JnL21lc3NhZ2UtaWQvZjNmMTUxZjctYzRkZC0xNjQ2LWI5OTgtZjYwYmQ2MjE3ZGQzQDJu ZHF1YWRyYW50LmNvbQotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2NhY2hlL3JlbGNhY2hlLmMg fCA3ICsrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9zcmMvYmFja2VuZC91dGlscy9jYWNoZS9yZWxjYWNoZS5jIGIvc3JjL2JhY2tlbmQv dXRpbHMvY2FjaGUvcmVsY2FjaGUuYwppbmRleCA4NDYwOWUwNzI1Li5lMTM3MTllZTk3IDEw MDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9jYWNoZS9yZWxjYWNoZS5jCisrKyBiL3Ny Yy9iYWNrZW5kL3V0aWxzL2NhY2hlL3JlbGNhY2hlLmMKQEAgLTUxMzMsNiArNTEzMywxMyBA QCBHZXRSZWxhdGlvblB1YmxpY2F0aW9uQWN0aW9ucyhSZWxhdGlvbiByZWxhdGlvbikKIAlN ZW1vcnlDb250ZXh0IG9sZGN4dDsKIAlQdWJsaWNhdGlvbkFjdGlvbnMgKnB1YmFjdGlvbnMg PSBwYWxsb2MwKHNpemVvZihQdWJsaWNhdGlvbkFjdGlvbnMpKTsKIAorCS8qCisJICogSWYg bm90IHB1Ymxpc2hhYmxlLCBpdCBwdWJsaXNoZXMgbm8gYWN0aW9ucy4gIChwZ291dHB1dF9j aGFuZ2UoKSB3aWxsCisJICogaWdub3JlIGl0LikKKwkgKi8KKwlpZiAoIWlzX3B1Ymxpc2hh YmxlX3JlbGF0aW9uKHJlbGF0aW9uKSkKKwkJcmV0dXJuIHB1YmFjdGlvbnM7CisKIAlpZiAo cmVsYXRpb24tPnJkX3B1YmFjdGlvbnMpCiAJCXJldHVybiBtZW1jcHkocHViYWN0aW9ucywg cmVsYXRpb24tPnJkX3B1YmFjdGlvbnMsCiAJCQkJCSAgc2l6ZW9mKFB1YmxpY2F0aW9uQWN0 aW9ucykpOwotLSAKMi4yMS4wCgo= --------------0427DCA6ECC0F446C1E47E0A--