Message-ID: <6217260b-304c-4e7d-be3d-72be90f6948b@joeconway.com>
Date: Sat, 1 Nov 2025 08:50:53 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: contrib/sepgsql regression tests have been broken for months
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
References: <1613232.1761255361@sss.pgh.pa.us>
 <2e327a21-9954-4d05-aa9e-3b7fe926f39f@joeconway.com>
 <371f0ee1-8507-46e0-9090-6df2b14f0cd8@joeconway.com>
 <081073df-32ff-498c-abeb-2e5590888ad9@joeconway.com>
 <CAOYmi+mppi5iSgyVFv007o6YRh-4oFcP=v3Tv4VjGLxT9R7rWA@mail.gmail.com>
 <b485587f-c3ea-4089-b526-92dcd1809f6e@joeconway.com>
 <66541690-91c2-48e6-9c99-12c9af25012b@joeconway.com>
 <2919479.1761779546@sss.pgh.pa.us> <2922181.1761780963@sss.pgh.pa.us>
 <908d9ef9-2194-4333-a363-e41e1887de70@joeconway.com>
 <3861765.1761940094@sss.pgh.pa.us>
Content-Language: en-US
From: Joe Conway <mail@joeconway.com>
In-Reply-To: <3861765.1761940094@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/6217260b-304c-4e7d-be3d-72be90f6948b%40joeconway.com>
Precedence: bulk

On 10/31/25 15:48, Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
>> On 10/29/25 19:36, Tom Lane wrote:
>>> ... I think the new idea
>>> is to leave the module installed and active, which is kind
>>> of problematic if we want to also use TestSepgsql.pm in the
>>> back branches.
> 
>> I suppose one solution is to create a new buildfarm animal and then use 
>> rhino only for <= pg17 and <rhino-prime> only for pg18+
> 
> It looks like it'd work to revert to using TestSepgsql.pm in all
> branches.  You'd need to remove 'sepgsql' from PG_TEST_EXTRA so
> that v18/master don't try to run the conflicting 001_sepgsql.pl
> tests.

I'm not clear on whether this involves just undoing the recent changes I 
made, or if the buildfarm code itself needs changes.

FWIW I did this part:
> remove 'sepgsql' from PG_TEST_EXTRA

But what about "--enable-tap-tests"? That makes the full buildfarm cycle 
across all branches take something like 2.5 hours. I removed that part 
for now at least.

> We need a better idea about how the new test method can coexist
> with the old one, but for now I'd just like rhino to be running
> one or the other successfully ...

ok, back to the original configuration (although now with the latest 
buildfarm client)

-- 
Joe Conway
PostgreSQL Contributors Team
Amazon Web Services: https://aws.amazon.com