Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nO5AS-0001Yp-Sn for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Feb 2022 22:03:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nO59v-0007mm-9G for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Feb 2022 22:03:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nO59u-0007mV-J4 for pgsql-hackers@lists.postgresql.org; Sat, 26 Feb 2022 22:03:23 +0000 Received: from anastigmatix.net ([68.171.219.55]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nO59n-0002Gt-2g for pgsql-hackers@lists.postgresql.org; Sat, 26 Feb 2022 22:03:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=anastigmatix.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bu3r7ajtMorc2y5ctjXATVNrTv+8oKciRbdi1x4bvAI=; b=ZDOfP44ti6TaI9+zBTHQ6LyDDZ SDUx4EAT0IOhBLrOxf1d6/bZSxFQGE4DSDMTq2xxRFmUWAIN4dCY7bqBi36aI2F8YxMrLjg2KhQmk gKPJGe465joUFWOzLUYdjk83J5VWXTF3dBkzkBAJow+VYvhkH1bKKG40jjdilgiTbzY3jzFZz05lN 6AGK3JRrl3ifqFhBJT5WHlRUpD8ZRwK0/un6FORdqr3qHrhX+4FsVmyO10xHSZ1pjrT2sbrrjS1yq HBrtO0OTfj3NI0lLpePPKpE41m2ofabXKogm2aWhXuVpaTPI7Bb5X7t7h9f1YSw4cRg4Zh+I2ROYl 7K538rhA==; Received: from 50-102-16-206.prtg.in.frontiernet.net ([50.102.16.206]:44766) by bay.acenet.us with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1nO59k-009tCP-8V for pgsql-hackers@lists.postgresql.org; Sat, 26 Feb 2022 17:03:12 -0500 Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file To: pgsql-hackers@lists.postgresql.org References: <20220221172306.GA3698472@nathanxps13> <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org> From: Chapman Flack Message-ID: <621AA398.4080206@anastigmatix.net> Date: Sat, 26 Feb 2022 17:03:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bay.acenet.us X-AntiAbuse: Original Domain - lists.postgresql.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - anastigmatix.net X-Get-Message-Sender-Via: bay.acenet.us: authenticated_id: chap@anastigmatix.net X-Authenticated-Sender: bay.acenet.us: chap@anastigmatix.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02/26/22 11:48, Chapman Flack wrote: > This patch applies cleanly for me and passes installcheck-world. > I have not yet studied all of the changes in detail. I've now looked through the rest, and the only further thing I noticed was that xlog.c's do_pg_start_backup still has a tablespaces parameter to receive a List* of tablespaces if the caller wants, but this patch removes the comment describing it: - * If "tablespaces" isn't NULL, it receives a list of tablespaceinfo structs - * describing the cluster's tablespaces. which seems like collateral damage. Regards, -Chap