Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tXZxJ-00A9tx-5K for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Jan 2025 05:59:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tXZxH-00FW8T-Rk for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Jan 2025 05:59:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tXZxH-00FW82-In for pgsql-hackers@lists.postgresql.org; Tue, 14 Jan 2025 05:59:12 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tXZxG-000Iy9-19 for pgsql-hackers@postgresql.org; Tue, 14 Jan 2025 05:59:11 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 50E5x42r622083; Tue, 14 Jan 2025 00:59:04 -0500 From: Tom Lane To: John Naylor cc: Nathan Bossart , "Chiranmoy.Bhattacharya@fujitsu.com" , "Devanga.Susmitha@fujitsu.com" , "pgsql-hackers@postgresql.org" , "Ragesh.Hajela@fujitsu.com" Subject: Re: [PATCH] Hex-coding optimizations using SVE on ARM. In-reply-to: References: Comments: In-reply-to John Naylor message dated "Tue, 14 Jan 2025 12:27:30 +0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <622081.1736834344.1@sss.pgh.pa.us> Date: Tue, 14 Jan 2025 00:59:04 -0500 Message-ID: <622082.1736834344@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk John Naylor writes: > We can do about as well simply by changing the nibble lookup to a byte > lookup, which works on every compiler and architecture: I didn't attempt to verify your patch, but I do prefer addressing this issue in a machine-independent fashion. I also like the brevity of the patch (though it could do with some comments perhaps, not that the existing code has any). regards, tom lane