Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
To: Nathan Bossart <nathandbossart@gmail.com>
References: <eafdd15c-6597-f205-c2df-3fb3817ccbd4@pgmasters.net>
 <20220308221253.GA169440@nathanxps13> <622801BD.9020605@anastigmatix.net>
 <20220309154209.GU10577@tamriel.snowman.net>
 <CABUevExC0kaA9DY67tEgkbLBf6dmRtU9KgrLwSqVQjYPte7erQ@mail.gmail.com>
 <6228DFE7.4080802@anastigmatix.net>
 <20220309171923.GV10577@tamriel.snowman.net>
 <622900C8.40807@anastigmatix.net> <20220309222124.GB180567@nathanxps13>
 <62293417.8070104@anastigmatix.net> <20220310000622.GA225595@nathanxps13>
Cc: Stephen Frost <sfrost@snowman.net>, Magnus Hagander
 <magnus@hagander.net>, David Steele <david@pgmasters.net>,
 pgsql-hackers@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <622A941A.90909@anastigmatix.net>
Date: Thu, 10 Mar 2022 19:13:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <20220310000622.GA225595@nathanxps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/622A941A.90909%40anastigmatix.net>
Precedence: bulk

On 03/09/22 19:06, Nathan Bossart wrote:
> Done.  I went ahead and added "label => 'label'" for consistency.

Looks like this change to an example in func.sgml is not quite right:

-postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
+postgres=# SELECT * FROM pg_walfile_name_offset(pg_backup_stop());

pg_backup_stop returns a record now, not just lsn. So this works for me:

+postgres=# SELECT * FROM pg_walfile_name_offset((pg_backup_stop()).lsn);


Otherwise, all looks to be in good order.

Regards,
-Chap