From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>, Noah Misch <noah@leadboat.com>,
        jian he <jian.universality@gmail.com>,
        Kirill Reshke <reshkekirill@gmail.com>,
        Peter Eisentraut <peter@eisentraut.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CREATE SCHEMA ... CREATE DOMAIN support
In-reply-to: <aqGGiZfONuhkd25F@nathan>
References: 
 <CACJufxEwkAJuCutLQdsxCOJkAvDS=9KgbphMVkXtQP8te=nciA@mail.gmail.com>
 <1199006.1775444695@sss.pgh.pa.us> <1838711.1775503188@sss.pgh.pa.us>
 <20260904002924.a7.noahmisch@microsoft.com>
 <1504966.1788483626@sss.pgh.pa.us>
 <20260904035154.0b.noahmisch@microsoft.com>
 <1566169.1788531712@sss.pgh.pa.us>
 <20260904180712.cc.noahmisch@microsoft.com>
 <1584523.1788550238@sss.pgh.pa.us>
 <57046562-8fe6-4663-b4d7-724d195f38f7@iki.fi> <aqGGiZfONuhkd25F@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Wed, 09 Sep 2026 11:17:13 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <627672.1788972291.1@sss.pgh.pa.us>
Date: Wed, 09 Sep 2026 12:44:51 -0400
Message-ID: <627673.1788972291@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/627673.1788972291%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Wed, Sep 09, 2026 at 06:53:58PM +0300, Heikki Linnakangas wrote:
>> Reverting seems like the safest thing to do. This is a really niche thing,
>> but whatever behavior we pick, we'll be stuck with it for a long time. If
>> we're not 100% certain about the new behavior, better to take a step back
>> and discuss and design it with more time.

> +1

After looking at the git history a bit, the relevant commits are

Branch: master Release: REL_19_BR [049b742da] 2026-06-23 14:12:03 -0400
    psql: Tighten heuristics for BEGIN/END within CREATE SCHEMA.
Branch: master Release: REL_19_BR [d51697484] 2026-04-06 15:16:25 -0400
    Support more object types within CREATE SCHEMA.
Branch: master Release: REL_19_BR [404db8f9e] 2026-04-06 15:16:25 -0400
    Execute foreign key constraints in CREATE SCHEMA at the end.
Branch: master Release: REL_19_BR [a9c350d9e] 2026-04-06 15:16:25 -0400
    Don't try to re-order the subcommands of CREATE SCHEMA.

It looks like it might be possible to revert a9c350d9e and d51697484
while keeping 404db8f9e, which would preserve a feature clearly
required by the SQL standard (F311-01, "Support for circular
references in that <referential constraint definition>s in two
different <table definition>s may reference columns in the other
table") while not breaking compatibility with our pre-19 behavior.
Any opinions about whether that's a good thing to try to do, rather
than a wholesale revert?

I'm also inclined to keep this bit of 049b742da:

    This patch also fixes what seems to me (tgl) a small bug: \;
    would reset BEGIN/END detection even when inside parens or BEGIN.
    That's unlike what a plain semicolon would do, and no such effect
    is suggested by the documentation.

			regards, tom lane