Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pj5Cp-0007qg-3g for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Apr 2023 21:25:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pj5Cn-0003Zl-P8 for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Apr 2023 21:25:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pj5Cn-0003ZU-7d for pgsql-hackers@lists.postgresql.org; Sun, 02 Apr 2023 21:25:41 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pj5Ck-0003hr-Kc for pgsql-hackers@postgresql.org; Sun, 02 Apr 2023 21:25:39 +0000 Received: by mail-pg1-x530.google.com with SMTP id z10so16329784pgr.8 for ; Sun, 02 Apr 2023 14:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; t=1680470737; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=NHbN6YCTCI6rl+1+F+ngxZjKUpe3HNMIeFjRYIKwK2M=; b=CrrGTqULgifFvyck6ucuhpJxuyCbVdjjGksReOV2HN2fLqEPUEe/CLbGhhIoi8SKDZ gmmvT9Y2ku2wv0p/h2lHs1977FY8Id2QKPi23z3LrJqfojrNQu4Tf4rTDlL0WuRlb9Zz Rqxv6fE/nZwIDYFuslCFj5lOc5IF++bs0YmRlIYdfZetWlwhUtslTxbyxVkjWB3TCNO8 SZ6jCwlrAfke0egeGjAiFMs9IU6sGrjxvRlpYqCEp4YvMbgAhKiVR5bKgA9WvI8EknX6 6FEFgCOoagmP0KX/+jB0xPudlOJFMpsjdZPGzPx0TtyTX5n9m2RogUxBG31t+k2eCfz0 aR9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680470737; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NHbN6YCTCI6rl+1+F+ngxZjKUpe3HNMIeFjRYIKwK2M=; b=sPoWiiOEA1nhjQ5KKA2JWAz8JiGiN+QQg1ZjlY/IGa9SUoOtxR4hpe7DSFPx02cClE lkC5yr/QmToL4RBCV8aouovEdlL9FXoaYoIBGm50PptoFkKSLh29sQtbn5v93QXWSUnZ +tV9dST7/57n7CuoIOdZ9zZQTOw9XQLX07VBS+yl+B04CSS0ekRz+I3HMvSi9y2DUBvp J9zcKNrnO5pxd3b+6YLmvUyCcyc1Y3K75jHZvESYLNSzqzAY5VdEV4ttEcfvKjGA7y9f oVbZ2eSp2v0r2cED6QeabFSb+gcX7LNY3kHuy7Rvli8gEV1DEg5uSbSyN6yi8BeOGKgt VvyQ== X-Gm-Message-State: AAQBX9fdVaDBWPYySMwkOIG0U0e8BvoQHMm+OMio8EiXnz1tPCnkRQA/ i6ECaUcQBzLb6zZDgbTc4qWwXA== X-Google-Smtp-Source: AKy350bHz2FWMxxk79Z+G6hYLIZTqcnd2ZtPX45z7u2Kw+lx5oR0ya2KQ+UxNQKdSwfWVVffmbpa6Q== X-Received: by 2002:a62:3816:0:b0:62d:dadd:6419 with SMTP id f22-20020a623816000000b0062ddadd6419mr10741286pfa.17.1680470737304; Sun, 02 Apr 2023 14:25:37 -0700 (PDT) Received: from jeff-laptop.lan (c-73-170-46-202.hsd1.ca.comcast.net. [73.170.46.202]) by smtp.gmail.com with ESMTPSA id c23-20020aa78c17000000b0062c0c3da6b8sm5610742pfd.13.2023.04.02.14.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 14:25:36 -0700 (PDT) Message-ID: <62a99b2751ee92e0761250fcf4a63593ae1d175c.camel@j-davis.com> Subject: Re: Minimal logical decoding on standbys From: Jeff Davis To: "Drouvot, Bertrand" , Andres Freund Cc: Robert Haas , Thomas Munro , Alvaro Herrera , Ibrar Ahmed , Amit Khandekar , fabriziomello@gmail.com, tushar , Rahila Syed , pgsql-hackers Date: Sun, 02 Apr 2023 14:25:35 -0700 In-Reply-To: References: <05c0c4f3-82eb-bc6d-c876-5a265c05927b@gmail.com> <20230106034036.2m4qnn7ep7b5ipet@awork3.anarazel.de> <490206c5-bcde-e558-628a-dc67dae4d439@gmail.com> <20230119024617.jzsgpcrgjdc6ysge@awork3.anarazel.de> <94d9d47e-72f4-393a-246e-e3fe8db7b741@gmail.com> <2d314c22b9e03415aa1c7d8fd1f698dae60effa7.camel@j-davis.com> <061eeb26-156e-6011-02b6-b4b1422e2aa6@gmail.com> <8a7da0c2-b7fe-1c78-4e47-a16239bf4839@gmail.com> <6ab352de1553c1e3d0c7d97c038dc470ca51e772.camel@j-davis.com> <4df984c8-3adb-3b69-0e4e-a491097862ce@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 2023-03-31 at 02:44 -0700, Jeff Davis wrote: > Thank you, done. I think the nearby line was also wrong, returning > true > when there was no timeout. I combined the lines and got rid of the > early return so it can check the list and timeout condition like > normal. Attached. On second (third?) thought, I think I was right the first time. It passes the flag WL_EXIT_ON_PM_DEATH (included in the ConditionVariableWaitSet), so a WL_POSTMASTER_DEATH event should not be returned. Also, I think the early return is correct. The current code in ConditionVariableTimedSleep() still checks the wait list even if WaitLatch() returns WL_TIMEOUT (it ignores the return), but I don't see why it can't early return true. For a socket event in ConditionVariableEventSleep() I think it should early return false. Regards, Jeff Davis