Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3G88-0013UD-0B for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Mar 2026 16:21:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w3G86-0012jA-1p for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Mar 2026 16:21:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3G86-0012j2-0W for pgsql-hackers@lists.postgresql.org; Thu, 19 Mar 2026 16:21:50 +0000 Received: from mail-dl1-x1236.google.com ([2607:f8b0:4864:20::1236]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w3G84-000000001hq-3QIL for pgsql-hackers@lists.postgresql.org; Thu, 19 Mar 2026 16:21:49 +0000 Received: by mail-dl1-x1236.google.com with SMTP id a92af1059eb24-12a693cdf29so742996c88.0 for ; Thu, 19 Mar 2026 09:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773937307; x=1774542107; darn=lists.postgresql.org; h=content-language:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=YtqRHCzBnxFtHoNIUoS89jbjl5lrb0b8BEFaFDJtv6M=; b=MME233ExwNzjzFAhnQCmy5iMWdZZkYWZCQn2zJhg1yCkYhzGbli/HDRMQDB4I0+LzL 5UrrPFTIP44zweZqn+MAT3ynlXMnoWCYBcxWey94J8DEoj0nZ+CU4TdlPMoHfZbxmiGN qN588v/Bwte4htuMBi9CkgkgUCoYx6+FdjNK6L3U3hrsN1C82heIPDWlt7TNvb3tNolt xsRZTn21YQVHlIymlRoi0dDyfsfqV7CeM4owbs9M+Ih+oEmaIPitIkXacWlhyaXsDQf9 XhfPlOADuCa4MItCz7J6A+CwQTHO1TH8L3IAd4Lw2rPUVl+psOxzbB/2HqnpEL+WKwpH OgGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773937307; x=1774542107; h=content-language:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YtqRHCzBnxFtHoNIUoS89jbjl5lrb0b8BEFaFDJtv6M=; b=oofcwQtYm1p+S0XKrYMPVXfv1CmL9PjRGfN/wQCX6Dx0HzGzsdDSgwRkKBBnw+kTVi /yYIYn0Ti7GKP8j8dYX0/qUSmuN7dt+3xq1qQ0saGSYuXyxu/NhhwEMEpFwk/aam7MMa ZN6YVkR3QgBcrG4nu412G7NW7dRhtYe8T32+rY+NZdJ/U2F7L+pS0q6zleT68ace8hLf WJwltXdBJlQMrhJjv8MSfACDvTCO+4U4Zcm/88beOs5iBOYN9V6yS2TBRXk3PC2zTJTG 4YuuSWUWAGvFqsnMHWH8A2nAWFodcg/LizqzPusrua/kTqGys+r141k9AIIzd1U1pBMw eIHw== X-Gm-Message-State: AOJu0YxuM+B+2rjmCLVgTnbkcrtRYt2lyyyoI832zOsRZQTGMpweAoGI +4VOSqwdv9z0wetXZaRRHPq5MGJ/SktjdYvInwUW+LRHQOM4fHVbnZRr2C5vgg== X-Gm-Gg: ATEYQzx2Ng1eSygU2DyoTAXOrVbOl0eutZtvQXH1nP5oIvaymqN5o259kg0jnXJ1TzQ 7poxKxq8Jq5NCF2RrG+eA/SxSQm8A5BPLsAU9HVougvAu/n1jDvkk1/AclKocj8WMfyY3mDZzIp Hq6HP2p39Ldskn6UHOA6pmUchsgdWCFsETiJZoOkx+REvOU5G7Rd2ARkVLiAn9uJ7gEHWiuPNoL PfHYxF7GuX0ZOMlG5IWZaRuSltpmi5toy4RpPbvWwFBbS0UoL2oyC09qx+4tJgnwRpXjixugBbm IaiD69YyDkVess9EdB7jd/YWjfNOohLz+MtVooLOb5K80RXwyKeh+aWh4crxUuoKq7XVu1tbynU /EOQjoEbTFZXVS2fkSGVGYAFH+MYzHhb0RirxLcdO7Qf/ZadgNa5kgTutjNKHPR0iqEQ12ZrBFK TX2uPD5nJ8WpFrY6qZ0rvekyyYek8cVVOMLeq9giIY2L/5xAeLCmbuKx9OhmQtlmXwLyOA3irjE QeEPoF0HORStZspOctoAnQXH21V X-Received: by 2002:a05:7300:2151:b0:2ba:749f:81a7 with SMTP id 5a478bee46e88-2c0f410c2a1mr1733341eec.21.1773937306779; Thu, 19 Mar 2026 09:21:46 -0700 (PDT) Received: from ?IPV6:2601:647:4402:c950:1c24:c945:74ae:1704? ([2601:647:4402:c950:1c24:c945:74ae:1704]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e53b5235sm8781286eec.8.2026.03.19.09.21.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 09:21:46 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------HgfkVlV0v0y00HEgtp0ZzfSx" Message-ID: <62bbe34d-2315-4b42-b768-56d901aa83e1@gmail.com> Date: Thu, 19 Mar 2026 09:21:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jianghua Yang Subject: [PATCH] Fix fd leak in pg_dump compression backends when dup()+fdopen() fails To: pgsql-hackers@lists.postgresql.org Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------HgfkVlV0v0y00HEgtp0ZzfSx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi,   I found a file descriptor leak in the pg_dump compression backends   (gzip, lz4, zstd, and the uncompressed "none" backend), introduced   in commit e9960732a9 ("Introduce a generic pg_dump compression API",   PostgreSQL 16).   == The Bug ==   All four compression open functions use this pattern when an existing   file descriptor is passed in:       if (fd >= 0)           fp = fdopen(dup(fd), mode);   /* or gzdopen() */       if (fp == NULL)           return false;                 /* dup'd fd is leaked here */   The problem is that dup(fd) and fdopen()/gzdopen() are two separate   steps, and their failure modes must be handled independently:   1. If dup() fails (returns -1), no fd is created -- this case was      not checked at all in the original code.   2. If dup() succeeds but fdopen()/gzdopen() fails (e.g., due to a      failed malloc(3) for the FILE structure), POSIX explicitly states:        "If the fdopen() function fails, the file descriptor is         not closed."        -- POSIX.1-2017, fdopen() specification      The duplicated fd therefore remains open with no owner, leaking      until the process exits.   == When Can dup() Fail? ==   The most realistic trigger for dup() returning EMFILE is parallel   pg_dump (pg_dump -j N) against a large database.  Each worker opens   multiple file descriptors for tables, indexes, TOC files, and   compression streams simultaneously.  On systems with a low per-process   fd limit (e.g., ulimit -n 1024), or when dumping a schema with a very   large number of objects, the process fd count can approach the limit.   At that point, dup() fails with EMFILE and the subsequent NULL-check   on fp returns false without any cleanup.   While fdopen() failure (EMFILE/OOM) is less common, it is equally   incorrect to ignore -- and it is precisely the case that POSIX calls   out as the caller's responsibility to close.   == The Fix ==   Save the result of dup() in a local variable.  Check it immediately.   If fdopen()/gzdopen() subsequently fails, explicitly close the   duplicated fd before returning false.       if (fd >= 0)       {           int dup_fd = dup(fd);           if (dup_fd < 0)               return false;           fp = fdopen(dup_fd, mode);           if (fp == NULL)           {               close(dup_fd);   /* POSIX: fdopen does not close on failure */               return false;           }       }       else       {           fp = fopen(path, mode);           if (fp == NULL)               return false;       }   The zstd fix additionally ensures that the previously allocated   zstdcs structure is freed on all new failure paths.   == Affected Versions ==   PostgreSQL 16 and 17, and current master.   The compress_* files were introduced in commit e9960732a9 (Feb 2023).   == Patch ==   Patch attached.  It applies cleanly to current master (as of   commit 18bcdb75d15).   Regards,   Jianghua Yang --------------HgfkVlV0v0y00HEgtp0ZzfSx Content-Type: application/octet-stream; name="0001-Fix-file-descriptor-leak-when-dup-fdopen-gzdopen-fai.patch" Content-Disposition: attachment; filename*0="0001-Fix-file-descriptor-leak-when-dup-fdopen-gzdopen-fai.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1OWEzYzA0MjU5NjA0ODNmNzNiNmMzNTIyNjg5NDlhMGM0NGI2NzdhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaWFuZ2h1YSBZYW5nIDx5amhqc3R6QGdtYWlsLmNv bT4KRGF0ZTogVGh1LCAxOSBNYXIgMjAyNiAwOTowNjozMSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBmaWxlIGRlc2NyaXB0b3IgbGVhayB3aGVuIGR1cCgpK2Zkb3BlbigpL2d6ZG9w ZW4oKSBmYWlscwogaW4gcGdfZHVtcCBjb21wcmVzc2lvbiBiYWNrZW5kcwoKV2hlbiBmZCA+ PSAwLCB0aGUgY29tcHJlc3Npb24gb3BlbiBmdW5jdGlvbnMgY2FsbGVkIGZkb3BlbihkdXAo ZmQpLCBtb2RlKQpvciBnemRvcGVuKGR1cChmZCksIG1vZGUpIGRpcmVjdGx5LiBJZiBkdXAo KSBzdWNjZWVkZWQgYnV0IGZkb3BlbigpL2d6ZG9wZW4oKQpmYWlsZWQsIHRoZSBkdXBsaWNh dGVkIGZpbGUgZGVzY3JpcHRvciB3YXMgbGVha2VkIGJlY2F1c2UgUE9TSVggc3BlY2lmaWVz IHRoYXQKZmRvcGVuKCkgZG9lcyBub3QgY2xvc2UgdGhlIGZkIG9uIGZhaWx1cmUuCgpGaXgg Ynkgc2F2aW5nIHRoZSBkdXAoKSByZXN1bHQgaW4gYSBsb2NhbCB2YXJpYWJsZSBhbmQgZXhw bGljaXRseSBjYWxsaW5nCmNsb3NlKCkgb24gaXQgaWYgdGhlIHN1YnNlcXVlbnQgd3JhcHBp bmcgY2FsbCBmYWlscy4KCkFmZmVjdGVkIGJhY2tlbmRzOiBjb21wcmVzc19nemlwLmMsIGNv bXByZXNzX2x6NC5jLCBjb21wcmVzc19ub25lLmMsCmNvbXByZXNzX3pzdGQuYy4gVGhlIHpz dGQgZml4IGFsc28gZW5zdXJlcyBwZ19mcmVlKHpzdGRjcykgaXMgY2FsbGVkIG9uIGFsbApm YWlsdXJlIHBhdGhzIGFmdGVyIHRoZSBhbGxvY2F0aW9uLgotLS0KIHNyYy9iaW4vcGdfZHVt cC9jb21wcmVzc19nemlwLmMgfCAyMCArKysrKysrKysrKysrKysrLS0tLQogc3JjL2Jpbi9w Z19kdW1wL2NvbXByZXNzX2x6NC5jICB8IDI3ICsrKysrKysrKysrKysrKysrKysrKystLS0t LQogc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX25vbmUuYyB8IDIwICsrKysrKysrKysrKysr KystLS0tCiBzcmMvYmluL3BnX2R1bXAvY29tcHJlc3NfenN0ZC5jIHwgMjggKysrKysrKysr KysrKysrKysrKysrKy0tLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCA3NiBpbnNlcnRpb25zKCsp LCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2R1bXAvY29tcHJl c3NfZ3ppcC5jIGIvc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX2d6aXAuYwppbmRleCBjOWNl OGE1M2FhYS4uNjBjNTUzYmEyNWEgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC9jb21w cmVzc19nemlwLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX2d6aXAuYwpAQCAt Mzg2LDEyICszODYsMjQgQEAgR3ppcF9vcGVuKGNvbnN0IGNoYXIgKnBhdGgsIGludCBmZCwg Y29uc3QgY2hhciAqbW9kZSwgQ29tcHJlc3NGaWxlSGFuZGxlICpDRkgpCiAJCXN0cmNweSht b2RlX2NvbXByZXNzaW9uLCBtb2RlKTsKIAogCWlmIChmZCA+PSAwKQotCQlnemZwID0gZ3pk b3BlbihkdXAoZmQpLCBtb2RlX2NvbXByZXNzaW9uKTsKKwl7CisJCWludAkJCWR1cF9mZCA9 IGR1cChmZCk7CisKKwkJaWYgKGR1cF9mZCA8IDApCisJCQlyZXR1cm4gZmFsc2U7CisJCWd6 ZnAgPSBnemRvcGVuKGR1cF9mZCwgbW9kZV9jb21wcmVzc2lvbik7CisJCWlmIChnemZwID09 IE5VTEwpCisJCXsKKwkJCWNsb3NlKGR1cF9mZCk7CisJCQlyZXR1cm4gZmFsc2U7CisJCX0K Kwl9CiAJZWxzZQorCXsKIAkJZ3pmcCA9IGd6b3BlbihwYXRoLCBtb2RlX2NvbXByZXNzaW9u KTsKLQotCWlmIChnemZwID09IE5VTEwpCi0JCXJldHVybiBmYWxzZTsKKwkJaWYgKGd6ZnAg PT0gTlVMTCkKKwkJCXJldHVybiBmYWxzZTsKKwl9CiAKIAlDRkgtPnByaXZhdGVfZGF0YSA9 IGd6ZnA7CiAKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9jb21wcmVzc19sejQuYyBi L3NyYy9iaW4vcGdfZHVtcC9jb21wcmVzc19sejQuYwppbmRleCAwYWE1MTlmYmI2Ny4uMGE3 ODcyMTE2ZTcgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC9jb21wcmVzc19sejQuYwor KysgYi9zcmMvYmluL3BnX2R1bXAvY29tcHJlc3NfbHo0LmMKQEAgLTcxNSwxMyArNzE1LDMw IEBAIExaNFN0cmVhbV9vcGVuKGNvbnN0IGNoYXIgKnBhdGgsIGludCBmZCwgY29uc3QgY2hh ciAqbW9kZSwKIAlMWjRTdGF0ZSAgICpzdGF0ZSA9IChMWjRTdGF0ZSAqKSBDRkgtPnByaXZh dGVfZGF0YTsKIAogCWlmIChmZCA+PSAwKQotCQlzdGF0ZS0+ZnAgPSBmZG9wZW4oZHVwKGZk KSwgbW9kZSk7CisJeworCQlpbnQJCQlkdXBfZmQgPSBkdXAoZmQpOworCisJCWlmIChkdXBf ZmQgPCAwKQorCQl7CisJCQlzdGF0ZS0+ZXJyY29kZSA9IGVycm5vOworCQkJcmV0dXJuIGZh bHNlOworCQl9CisJCXN0YXRlLT5mcCA9IGZkb3BlbihkdXBfZmQsIG1vZGUpOworCQlpZiAo c3RhdGUtPmZwID09IE5VTEwpCisJCXsKKwkJCXN0YXRlLT5lcnJjb2RlID0gZXJybm87CisJ CQljbG9zZShkdXBfZmQpOworCQkJcmV0dXJuIGZhbHNlOworCQl9CisJfQogCWVsc2UKLQkJ c3RhdGUtPmZwID0gZm9wZW4ocGF0aCwgbW9kZSk7Ci0JaWYgKHN0YXRlLT5mcCA9PSBOVUxM KQogCXsKLQkJc3RhdGUtPmVycmNvZGUgPSBlcnJubzsKLQkJcmV0dXJuIGZhbHNlOworCQlz dGF0ZS0+ZnAgPSBmb3BlbihwYXRoLCBtb2RlKTsKKwkJaWYgKHN0YXRlLT5mcCA9PSBOVUxM KQorCQl7CisJCQlzdGF0ZS0+ZXJyY29kZSA9IGVycm5vOworCQkJcmV0dXJuIGZhbHNlOwor CQl9CiAJfQogCiAJcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2R1bXAv Y29tcHJlc3Nfbm9uZS5jIGIvc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX25vbmUuYwppbmRl eCBkODYyZDhjYTZlOS4uNzQzZTJjZTk0YjUgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVt cC9jb21wcmVzc19ub25lLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX25vbmUu YwpAQCAtMjMxLDEyICsyMzEsMjQgQEAgb3Blbl9ub25lKGNvbnN0IGNoYXIgKnBhdGgsIGlu dCBmZCwgY29uc3QgY2hhciAqbW9kZSwgQ29tcHJlc3NGaWxlSGFuZGxlICpDRkgpCiAJQXNz ZXJ0KENGSC0+cHJpdmF0ZV9kYXRhID09IE5VTEwpOwogCiAJaWYgKGZkID49IDApCi0JCUNG SC0+cHJpdmF0ZV9kYXRhID0gZmRvcGVuKGR1cChmZCksIG1vZGUpOworCXsKKwkJaW50CQkJ ZHVwX2ZkID0gZHVwKGZkKTsKKworCQlpZiAoZHVwX2ZkIDwgMCkKKwkJCXJldHVybiBmYWxz ZTsKKwkJQ0ZILT5wcml2YXRlX2RhdGEgPSBmZG9wZW4oZHVwX2ZkLCBtb2RlKTsKKwkJaWYg KENGSC0+cHJpdmF0ZV9kYXRhID09IE5VTEwpCisJCXsKKwkJCWNsb3NlKGR1cF9mZCk7CisJ CQlyZXR1cm4gZmFsc2U7CisJCX0KKwl9CiAJZWxzZQorCXsKIAkJQ0ZILT5wcml2YXRlX2Rh dGEgPSBmb3BlbihwYXRoLCBtb2RlKTsKLQotCWlmIChDRkgtPnByaXZhdGVfZGF0YSA9PSBO VUxMKQotCQlyZXR1cm4gZmFsc2U7CisJCWlmIChDRkgtPnByaXZhdGVfZGF0YSA9PSBOVUxM KQorCQkJcmV0dXJuIGZhbHNlOworCX0KIAogCXJldHVybiB0cnVlOwogfQpkaWZmIC0tZ2l0 IGEvc3JjL2Jpbi9wZ19kdW1wL2NvbXByZXNzX3pzdGQuYyBiL3NyYy9iaW4vcGdfZHVtcC9j b21wcmVzc196c3RkLmMKaW5kZXggY2YyZGIyNjQ5YWMuLjY4ZjFkODE1OTE3IDEwMDY0NAot LS0gYS9zcmMvYmluL3BnX2R1bXAvY29tcHJlc3NfenN0ZC5jCisrKyBiL3NyYy9iaW4vcGdf ZHVtcC9jb21wcmVzc196c3RkLmMKQEAgLTUyMywxNCArNTIzLDMwIEBAIFpzdGRfb3Blbihj b25zdCBjaGFyICpwYXRoLCBpbnQgZmQsIGNvbnN0IGNoYXIgKm1vZGUsCiAJfQogCiAJaWYg KGZkID49IDApCi0JCWZwID0gZmRvcGVuKGR1cChmZCksIG1vZGUpOwotCWVsc2UKLQkJZnAg PSBmb3BlbihwYXRoLCBtb2RlKTsKKwl7CisJCWludAkJCWR1cF9mZCA9IGR1cChmZCk7CiAK LQlpZiAoZnAgPT0gTlVMTCkKKwkJaWYgKGR1cF9mZCA8IDApCisJCXsKKwkJCXBnX2ZyZWUo enN0ZGNzKTsKKwkJCXJldHVybiBmYWxzZTsKKwkJfQorCQlmcCA9IGZkb3BlbihkdXBfZmQs IG1vZGUpOworCQlpZiAoZnAgPT0gTlVMTCkKKwkJeworCQkJY2xvc2UoZHVwX2ZkKTsKKwkJ CXBnX2ZyZWUoenN0ZGNzKTsKKwkJCXJldHVybiBmYWxzZTsKKwkJfQorCX0KKwllbHNlCiAJ ewotCQlwZ19mcmVlKHpzdGRjcyk7Ci0JCXJldHVybiBmYWxzZTsKKwkJZnAgPSBmb3Blbihw YXRoLCBtb2RlKTsKKwkJaWYgKGZwID09IE5VTEwpCisJCXsKKwkJCXBnX2ZyZWUoenN0ZGNz KTsKKwkJCXJldHVybiBmYWxzZTsKKwkJfQogCX0KIAogCXpzdGRjcy0+ZnAgPSBmcDsKLS0g CjIuNTAuMSAoQXBwbGUgR2l0LTE1NSkKCg== --------------HgfkVlV0v0y00HEgtp0ZzfSx--