Content-Type: multipart/mixed; boundary="------------bZdOnSnP0fE7GyZkat5OXKEF"
Message-ID: <62d5fa6e-4fe5-4527-a0a2-5dd32e6b3cf7@basealt.ru>
Date: Fri, 28 Mar 2025 16:12:37 +0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Assert failure in base_yyparse
To: Richard Guo <guofenglinux@gmail.com>
References: <6bac9886-65bf-4cec-96bd-e304159f28db@basealt.ru>
 <CAMbWs4-9Zde_MU8h-hvfGv6gpi98ZWUFTwESN3DaS0hzJECAww@mail.gmail.com>
 <CAMbWs49Z4OV77=9mD0BgHqSUOdLdO3YkbQVunCAgfFKU2WcjVA@mail.gmail.com>
Content-Language: en-US
From: =?UTF-8?B?0JXQstCz0LXQvdC40Lkg0JPQvtGA0LHQsNC90LXQsg==?=
 <gorbanyoves@basealt.ru>
Cc: pgsql-hackers@lists.postgresql.org
In-Reply-To: 
 <CAMbWs49Z4OV77=9mD0BgHqSUOdLdO3YkbQVunCAgfFKU2WcjVA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/62d5fa6e-4fe5-4527-a0a2-5dd32e6b3cf7%40basealt.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------bZdOnSnP0fE7GyZkat5OXKEF
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

> Also, I think IsA is a better choice for checking the node type.

Agree, IsA is better. Fixed in the patch.


> On Fri, Mar 28, 2025 at 6:05 PM Richard Guo <guofenglinux@gmail.com> wrote:
> Hmm, I wonder if we should allow the use of the 'is_not_null' keyword
> in xmltable.  According to the doc, it seems that users should declare
> NULL or NOT NULL for a column by specifying [NOT NULL | NULL] for the
> column.
>
> Thanks
> Richard

If you replace is_not_null with NOT NULL in the query, everything works 
correctly.
It seems that is_not_null is an incorrect keyword and it should not be 
used, but I don't understand how it gets here.

Best regards,
Evgeniy


--------------bZdOnSnP0fE7GyZkat5OXKEF
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Fix-usage-of-is_not_null-in-xmltable.patch"
Content-Disposition: attachment;
 filename="0001-Fix-usage-of-is_not_null-in-xmltable.patch"
Content-Transfer-Encoding: base64

RnJvbSBkZTY2YTdhYzc3NmI4MjdjYmE3NDhlMGEzNThiNmQzOTExNzkwZTIzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFdmdlbml5IEdvcmJhbmV2IDxnb3JiYW55b3Zlc0Bi
YXNlYWx0LnJ1PgpEYXRlOiBGcmksIDI4IE1hciAyMDI1IDE1OjU0OjM3ICswNjAwClN1Ympl
Y3Q6IFtQQVRDSF0gRml4IHVzYWdlIG9mIGlzX25vdF9udWxsIGluIHhtbHRhYmxlCgppc19u
b3RfbnVsbCBpcyBjb25zaWRlcmVkIGFzIGEgdmFsaWQga2V5d29yZCBpbiB4bWx0YWJsZSwg
YnV0IGl0IGdldHMgdGhlIHR5cGUgVF9BX0V4cHIKLS0tCiBzcmMvYmFja2VuZC9wYXJzZXIv
Z3JhbS55IHwgNSArKysrKwogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQoKZGlm
ZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BhcnNlci9ncmFtLnkgYi9zcmMvYmFja2VuZC9wYXJz
ZXIvZ3JhbS55CmluZGV4IDBmYzUwMmEzYTQwLi44NDc2MmMyNTExYiAxMDA2NDQKLS0tIGEv
c3JjL2JhY2tlbmQvcGFyc2VyL2dyYW0ueQorKysgYi9zcmMvYmFja2VuZC9wYXJzZXIvZ3Jh
bS55CkBAIC0xNDIzMiw2ICsxNDIzMiwxMSBAQCB4bWx0YWJsZV9jb2x1bW5fZWw6CiAJCQkJ
CQkJCQkJKGVycmNvZGUoRVJSQ09ERV9TWU5UQVhfRVJST1IpLAogCQkJCQkJCQkJCSBlcnJt
c2coImNvbmZsaWN0aW5nIG9yIHJlZHVuZGFudCBOVUxMIC8gTk9UIE5VTEwgZGVjbGFyYXRp
b25zIGZvciBjb2x1bW4gXCIlc1wiIiwgZmMtPmNvbG5hbWUpLAogCQkJCQkJCQkJCSBwYXJz
ZXJfZXJycG9zaXRpb24oZGVmZWwtPmxvY2F0aW9uKSkpOworCQkJCQkJCWlmICghSXNBKGRl
ZmVsLT5hcmcsIEJvb2xlYW4pKQorCQkJCQkJCQllcmVwb3J0KEVSUk9SLAorCQkJCQkJCQkJ
CShlcnJjb2RlKEVSUkNPREVfU1lOVEFYX0VSUk9SKSwKKwkJCQkJCQkJCQkgZXJybXNnKCJz
eW50YXggZXJyb3IgYXQgb3IgbmVhciBcIiVzXCIiLCBkZWZlbC0+ZGVmbmFtZSksCisJCQkJ
CQkJCQkJIHBhcnNlcl9lcnJwb3NpdGlvbihkZWZlbC0+bG9jYXRpb24pKSk7CiAJCQkJCQkJ
ZmMtPmlzX25vdF9udWxsID0gYm9vbFZhbChkZWZlbC0+YXJnKTsKIAkJCQkJCQludWxsYWJp
bGl0eV9zZWVuID0gdHJ1ZTsKIAkJCQkJCX0KLS0gCjIuNDIuMgoK

--------------bZdOnSnP0fE7GyZkat5OXKEF--