Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWH2f-0000K1-0I for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Mar 2022 12:21:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWH2d-0008E7-Pj for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Mar 2022 12:21:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWH2c-0008Dy-LO for pgsql-hackers@lists.postgresql.org; Mon, 21 Mar 2022 12:21:43 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWH2Z-0002iZ-Qr for pgsql-hackers@postgresql.org; Mon, 21 Mar 2022 12:21:41 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0C8675C01EE; Mon, 21 Mar 2022 08:21:39 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute4.internal (MEProxy); Mon, 21 Mar 2022 08:21:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=s6GCjM3Ow2LWsuOuVOJuLKYig2l4CxxpYDVjeu fsai8=; b=mtcDo885Mpi8ONSXPuO6cugHBx5oHW5SG5pb9y05aZd45KVLLu+jEX g+FRyPcGeq4VkmGsC25C95XjqFycbr1GmdYS7DDfgpqIDs2X2ILB4mlwuq2VaIEd 76V6MTaDoubj2BYTzDxsRXfO/o35Nw8RMvhF3W2jskkq/G6S4rJJaONdHKls9Vjs p+4s4/0BaMWB8C/chXJeCxvW+bCRTSTN2sA9wfmr7jAuKFdfbiCq6BTGeP38EXOE qSkRE55JMYA6on3z8cXvaxNRcP7zKxaNubPB/rjZ8jrWOh87+4CdpuYNbmIQdQwu ziHkK+hDz8dJMziok2uzIbpPNq2Q5Auw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=s6GCjM3Ow2LWsuOuV OJuLKYig2l4CxxpYDVjeufsai8=; b=dkyYp/p9eJ9w7Y1NkO3xuNBCR8Ck6B67a LPUwKeqhiNbNmsoh8qhsoEGNz7EUrzgSfgAxsfUe6PcqHQcpSxp6awgTJBT+zc4M pn2nO8f1qMF3jCvKWf4uEDkrShY4PSIn1ufbx3VzdSYTBnNKqnZXIlENGmpjsiBY bbHq/3tCA/F+xf25LzkadBItAwCZorF4Ukob3TC2Iz16Jmxm+W35W3TcsCqnotx1 kUQFwefmKrJ+1lg18WBLSbWpJtIuC8KXQMtEV+xjQ4HDp+Q77HsXOzNWOxa+NyhC UpkfU8F1g/P6Xv2uJOwwZAOMwS0cB4xQGFH7bZnnl05R66AZc9uBg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegfedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesrgdtreerreertdenucfhrhhomhepfdfguhhl vghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvghrthhordgtohhmqeenucggtf frrghtthgvrhhnpeejtefhuedvgffftdetvedufedtjeeuffekleevkefhveekgeelfefh jeehtdejgeenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvghulhgvrhesvghu lhgvrhhtohdrtghomh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9269AF60083; Mon, 21 Mar 2022 08:21:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4907-g25ce6f34a9-fm-20220311.001-g25ce6f34 Mime-Version: 1.0 Message-Id: <6320e1d2-b4fd-4e3e-9cae-3373fd6263fe@www.fastmail.com> In-Reply-To: References: <78a7ef21-bb27-f78a-521e-94ddb4d5c669@enterprisedb.com> <56e64628-940b-dca9-1388-872a914f8ea0@enterprisedb.com> Date: Mon, 21 Mar 2022 09:21:18 -0300 From: "Euler Taveira" To: "Amit Kapila" Cc: "Masahiko Sawada" , "osumi.takamichi@fujitsu.com" , "Peter Eisentraut" , "David G. Johnston" , "tanghy.fnst@fujitsu.com" , "vignesh C" , "Greg Nancarrow" , "houzj.fnst@fujitsu.com" , "Alexey Lesovsky" , pgsql-hackers Subject: Re: Skipping logical replication transactions on subscriber side Content-Type: multipart/alternative; boundary=15c3d8498c98470db9b96bbc79747fa7 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --15c3d8498c98470db9b96bbc79747fa7 Content-Type: text/plain On Mon, Mar 21, 2022, at 12:25 AM, Amit Kapila wrote: > I have fixed all the above comments as per your suggestion in the > attached. Do let me know if something is missed? Looks good to me. > > src/test/subscription/t/029_disable_on_error.pl | 94 ---------- > > src/test/subscription/t/029_on_error.pl | 183 +++++++++++++++++++ > > > > It seems you are removing a test for 705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33. > > I should also name 029_on_error.pl to something else such as 030_skip_lsn.pl or > > a generic name 030_skip_option.pl. > > > > As explained in my previous email, I don't think any change is > required for this comment but do let me know if you still think so? Oh, sorry about the noise. I saw mixed tests between the 2 new features and I was confused if it was intentional or not. -- Euler Taveira EDB https://www.enterprisedb.com/ --15c3d8498c98470db9b96bbc79747fa7 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Mon, Mar 21,= 2022, at 12:25 AM, Amit Kapila wrote:
I have fixed all the above comments as per y= our suggestion in the
attached. Do let me know if somethin= g is missed?
Looks good to me.

=
> src/test/= subscription/t/029_disable_on_error.pl |  94 ----------
> src/test/subscription/t/029_on_error.pl    &= nbsp;    | 183 +++++++++++++++++++
>
=
> It seems you are removing a test for 705e20f8550c0e8e47c= 0b6b20b5f5ffd6ffd9e33.
> I should also name 029_on_erro= r.pl to something else such as 030_skip_lsn.pl or
> a g= eneric name 030_skip_option.pl.
>

As explained in my previous email, I don't think any change is
required for this comment but do let me know if you still t= hink so?
Oh, sorry about the noise. I saw mix= ed tests between the 2 new features and I
was confused if = it was intentional or not.


--
Euler Taveira
EDB  = https://www.enterprisedb.com/=

--15c3d8498c98470db9b96bbc79747fa7--