From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@vmware.com>
cc: "peter.eisentraut@enterprisedb.com" <peter.eisentraut@enterprisedb.com>,
        "daniel@yesql.se" <daniel@yesql.se>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        "michael@paquier.xyz" <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
References: <3128896.1624742969@sss.pgh.pa.us>
 <18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
 <622907.1625084114@sss.pgh.pa.us> <630837.1625092151@sss.pgh.pa.us>
 <67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
Comments: In-reply-to Jacob Champion <pchampion@vmware.com>
	message dated "Wed, 30 Jun 2021 22:41:01 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <632282.1625093816.1@sss.pgh.pa.us>
Date: Wed, 30 Jun 2021 18:56:56 -0400
Message-ID: <632283.1625093816@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/632283.1625093816%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <pchampion@vmware.com> writes:
> On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
>> Looks like we'd have to make use of a dummy stamp-file, more or less
>> as attached.  Any objections?

> Spitballing -- if you don't like the stamp file, you could add the
> check to the end of the $(shlib) rule, surrounded by an ifeq check.
> Then .DELETE_ON_ERROR should take care of the rest, I think.

Hmm ... I'd been thinking we don't use .DELETE_ON_ERROR, but on
second look we do, so that could be a plausible approach.

On balance though, the separate rule seems better, because
.DELETE_ON_ERROR would destroy the evidence about why "nm"
failed, which could be annoying when investigating problems.

			regards, tom lane