Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzWBL-004a2h-0h for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Apr 2024 06:32:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rzWBJ-00C6H6-4E for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Apr 2024 06:32:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzWBH-00C6GG-Ad for pgsql-hackers@lists.postgresql.org; Wed, 24 Apr 2024 06:32:36 +0000 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzWBD-002ep6-8z for pgsql-hackers@postgresql.org; Wed, 24 Apr 2024 06:32:34 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 2CC1B1380197; Wed, 24 Apr 2024 02:32:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 24 Apr 2024 02:32:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1713940349; x=1714026749; bh=+o/ruKg8gyCzYtynd00W8DYjy/CDA8T2 RcXQ6P1AgAw=; b=moerJrPOXzGAmDP8V6jWLm2fEcpY5cRNB08tkqtZFxP2ZrAX 1vz3ssI6Yxbx51rhDtXwYjpv1pdNu6oSOjShXamDuqFrPlLgUJAJE91j+hNdnAeJ I6nLVK/zU3Fb6HG6+zYX1ZGP48AsQjjdywRyteRx2gwwQPmPBHrwdCBKgezFxNiY +il+N9BmfDNd4uVQhCHrOKLX8K1b91JTmi44KWE7FmUjFGRN0IYbc8ZaSoNoxbEG LrtYEASTZzEXSwk8bcLhmbSZKSb87m/Yz8pr7wWBbOY5ZAx0rfwt4r3wMI0q0x18 d2OQdZHiEYEsDcqRbYH1o3WR3N3rANu7AZf26g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1713940349; x= 1714026749; bh=+o/ruKg8gyCzYtynd00W8DYjy/CDA8T2RcXQ6P1AgAw=; b=H S9FqxxNp900Vn4MchUoUHyTb6Ura6EjlDFtR2DL8EhzCj78D1odRVbZOPPejIzMy TLHHh8YgXHShlmRTXIuD7nao6hTIJaR5jszt8vkJaxJbLpFYjd6ACHpLpGaLu5M9 lOfuZoDWZI/lJ6wO+j/3eWNdOCxVoCCVzvE58y99/IdcJHsexionsXptqENnhOrD vHdZALvcD49UpcJKoMyfbSveVCKUrSg4fY7GPS08A4Nw/YFhfZlApIPuBLVcwGaD dLU8d2un4dNg2yWTyQLL29h+6GPVdrycgjYFoRB6VLOKiBQ7qld+urjuMQKROgxa hBB5EpYNI7/yCJlyZmWAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudelvddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgse htjeertddtvdejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvght vghrsegvihhsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepgfejtdfhke eftdeugfeileehteeljeeghfeuledthfeutedvffdukeefjefhgeehnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnh htrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Apr 2024 02:32:28 -0400 (EDT) Message-ID: <634557bd-ac58-4c5d-8feb-e1ef0271c005@eisentraut.org> Date: Wed, 24 Apr 2024 08:32:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: ecpg_config.h symbol missing with meson To: Tom Lane Cc: pgsql-hackers References: <1580077.1713370500@sss.pgh.pa.us> Content-Language: en-US From: Peter Eisentraut In-Reply-To: <1580077.1713370500@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 17.04.24 18:15, Tom Lane wrote: > Peter Eisentraut writes: >> I checked the generated ecpg_config.h with make and meson, and the meson >> one is missing > >> #define HAVE_LONG_LONG_INT 1 > >> This is obviously quite uninteresting, since that is required by C99. >> But it would be more satisfactory if we didn't have discrepancies like >> that. Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for >> compatibility. >> ... >> Alternatively, we could remove the symbol from the make side. > > Think I'd vote for removing it, since we use it nowhere. > The ENABLE_THREAD_SAFETY precedent feels a little bit different, > since there's not the C99-requires-the-feature angle. Ok, fixed by removing instead.