From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zhihong Yu <zyu@yugabyte.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: silence compiler warning in brin.c
In-reply-to: 
 <CALNJ-vSfwr_vCiiSYVNmh8bH1ejyb4E06oczTcvARhz8wAxu0g@mail.gmail.com>
References: <20220601163537.GA2331988@nathanxps13>
 <CALNJ-vTvL-kvQ0CAbZxOvSR=PuOi1MbtywE=tdG2hhqSnZVkRw@mail.gmail.com>
 <626379.1654103181@sss.pgh.pa.us>
 <CALNJ-vSfwr_vCiiSYVNmh8bH1ejyb4E06oczTcvARhz8wAxu0g@mail.gmail.com>
Comments: In-reply-to Zhihong Yu <zyu@yugabyte.com>
	message dated "Wed, 01 Jun 2022 10:58:20 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <635070.1654106152.1@sss.pgh.pa.us>
Date: Wed, 01 Jun 2022 13:55:52 -0400
Message-ID: <635071.1654106152@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/635071.1654106152%40sss.pgh.pa.us>
Precedence: bulk

Zhihong Yu <zyu@yugabyte.com> writes:
> Hi,

>     if (heapRel == NULL || heapoid != IndexGetRelation(indexoid, false))
>         ereport(ERROR,

> I wonder why the above check is not placed in the else block:

>     else
>         heapRel = NULL;

Because we don't want to throw that error until we've exhausted the
possibilities for throwing other errors.

			regards, tom lane