public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fixing code that ignores failure of XLogRecGetBlockTag
Date: Mon, 11 Apr 2022 17:44:45 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKG+4Xsn+b8tcXFizVy-mAHe0bR1qbCeHgq7ZnxMDzfSdvA@mail.gmail.com>
References: <[email protected]>
	<CA+TgmoaOdNdd3fBsM0U=OqDrxJZST3z0ayA4dqVVKhXVoZ0vQQ@mail.gmail.com>
	<CA+hUKG+4Xsn+b8tcXFizVy-mAHe0bR1qbCeHgq7ZnxMDzfSdvA@mail.gmail.com>

Thomas Munro <[email protected]> writes:
> On Tue, Apr 12, 2022 at 8:58 AM Robert Haas <[email protected]> wrote:
>> On Mon, Apr 11, 2022 at 2:20 PM Tom Lane <[email protected]> wrote:
>>> I think we should make this a little less fragile.  Since we
>>> already have XLogRecGetBlockTagExtended, I propose that callers
>>> that need to handle the case of no-such-block must use that,
>>> while XLogRecGetBlockTag throws an error.  The attached patch
>>> fixes that up, and also cleans up some random inconsistency
>>> about use of XLogRecHasBlockRef().

>> Looks reasonable.

> +1

Pushed, thanks for looking.

			regards, tom lane

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fixing code that ignores failure of XLogRecGetBlockTag
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox