Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: pgindent versus struct members and typedefs
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <afplW8DvRONDc1yl@nathan>
Date: Wed, 6 May 2026 09:29:36 +0800
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Rahila Syed <rahilasyed90@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <6356E089-A04E-4CAE-9385-C2ABD6844CD2@gmail.com>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
 <509793.1764715875@sss.pgh.pa.us> <afplW8DvRONDc1yl@nathan>
To: Nathan Bossart <nathandbossart@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/6356E089-A04E-4CAE-9385-C2ABD6844CD2%40gmail.com>
Precedence: bulk


> On May 6, 2026, at 05:47, Nathan Bossart <nathandbossart@gmail.com> =
wrote:
>=20
> On Tue, Dec 02, 2025 at 05:51:15PM -0500, Tom Lane wrote:
>> Chao Li <li.evan.chao@gmail.com> writes:
>>> On Dec 3, 2025, at 06:00, Nathan Bossart <nathandbossart@gmail.com> =
wrote:
>>>> I tried to fix pgindent for a few, but the code is basically =
impenetrable.
>>>> I didn't find any fixes upstream [0], either.  As noted above, we =
could
>>>> also fix it by avoiding the naming conflicts.  However, I can't =
imagine
>>>> that's worth the churn, and I've already spent way too much time on =
this,
>>>> so IMHO the best thing to do here is nothing.
>>=20
>>> I think that=E2=80=99s fine.
>>=20
>> Agreed, not worth the trouble to fool with.
>=20
> For fun, I spent some time with an AI tool to develop the attached fix =
for
> this problem.  The explanation seems reasonable to me, although I am =
by no
> means a pgindent expert.  When I looked at this in December, I did =
find
> this similar commit from upstream [0], but I failed to make the =
connection
> with last_u_d.  0002 is the result of a pgindent run after applying =
0001.
> You'll notice that it fixes the exact set of cases I found with grep
> upthread.
>=20
> [0] https://github.com/pstef/freebsd_indent/commit/afa2239
>=20
> --=20
> nathan
> =
<v1-0001-pgindent-Fix-spacing-after-when-member-name-match.patch><v1-0002-=
run-pgindent.patch>

=46rom 0002, the fix looks good. I tried to run the patched pgindent =
against all .c and .h files under src/ and contrib/, the result is =
exactly the same as 0002.

So, maybe worthy pushing before Tom running the annual pgindent.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/