From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Joel Jacobson" <joel@compiler.org>
cc: "Arseniy Mukhin" <arseniy.mukhin.dev@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
In-reply-to: <e0f950e2-8394-466c-bec9-4557c47bfd05@app.fastmail.com>
References: <9835b0a4-9121-47ac-9c44-427b8b1a7f1b@app.fastmail.com>
 <CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
 <e46886ff-4a49-47fb-a76f-3b2f012f1948@app.fastmail.com>
 <CAE7r3MLi9MRfysi+0AcEBzO-tR1PCDr40KT7E+Qgpa9WZHZhmg@mail.gmail.com>
 <e2e857de-f0bc-4c56-99ba-5d34d41dcdb0@app.fastmail.com>
 <14717.1779810009@sss.pgh.pa.us>
 <e0f950e2-8394-466c-bec9-4557c47bfd05@app.fastmail.com>
Comments: In-reply-to "Joel Jacobson" <joel@compiler.org>
	message dated "Wed, 27 May 2026 12:43:54 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <636960.1779899312.1@sss.pgh.pa.us>
Date: Wed, 27 May 2026 12:28:32 -0400
Message-ID: <636961.1779899312@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/636961.1779899312%40sss.pgh.pa.us>
Precedence: bulk

"Joel Jacobson" <joel@compiler.org> writes:
> On Tue, May 26, 2026, at 17:40, Tom Lane wrote:
>> (Both "listening" and "committed" appear in dozens of places in this
>> file that are not references to this flag, so TBH I'd rather use a
>> flag name that is not either of those words.  But I can't think of
>> a better name.)

> How about renaming listening to removeOnAbort and negating its meaning?

Okay, or at least I haven't a better idea.  Pushed after some more
fiddling with the comments.

			regards, tom lane