Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: doc: create table improvements
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <ab574da206f7cb0db340671d88eff4ae9d66e450.camel@cybertec.at>
Date: Tue, 16 Dec 2025 10:14:00 +0800
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 jian he <jian.universality@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <63CD263B-E821-43BB-9B22-48C48326D663@gmail.com>
References: 
 <CAKFQuwYfMV-2SdrP-umr5SVNSqTn378BUvHsebetp5=DhT494w@mail.gmail.com>
 <ec0bd3d2-3e15-4492-b93a-683c04ec345c@eisentraut.org>
 <CAKFQuwYk7NsEAEsPEUdbc_gXB0OR+gZzmBjDcUSe5JZuE+d_iw@mail.gmail.com>
 <ae5203d1f68267b1e67cfd32023ece1367689b83.camel@cybertec.at>
 <CACJufxFgZtLENzJkZZssKdWEfHo1hk9uyC0h3JcGJJb19XRJQQ@mail.gmail.com>
 <cbc03892163dbf67980e2863b784745517a516a5.camel@cybertec.at>
 <3c9aabf667db65e757dddbdad1a13d623170e970.camel@cybertec.at>
 <CAKFQuwaEo8dxUmVsmjkb4WBEtKHUazeaN1pwsbDpLsFdANDAkQ@mail.gmail.com>
 <ab574da206f7cb0db340671d88eff4ae9d66e450.camel@cybertec.at>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Archived-At: 
 <https://www.postgresql.org/message-id/63CD263B-E821-43BB-9B22-48C48326D663%40gmail.com>
Precedence: bulk


> On Oct 23, 2025, at 12:43, Laurenz Albe <laurenz.albe@cybertec.at> =
wrote:
>=20
> On Mon, 2025-10-20 at 07:41 -0400, David G. Johnston wrote:
>> I question whether =E2=80=9Cparameter=E2=80=9D is even the correct =
class to assign here
>> and so would rather avoid the issue by not assigning a class.
>=20
> Right.  I have removed the vestiges from my failed attempt to improve
> the "parameter" decorations.
>=20
>> =E2=80=9CIf none is specified, the data will be persistent=E2=80=9D =
would be better
>> written =E2=80=9CIf unspecified the data will be persistent=E2=80=9D =
(or, =E2=80=9Cif not specified=E2=80=A6=E2=80=9D)
>=20
> I decided to use the trusted phrasing "by default".
>=20
>> Everything else looks good.
>=20
> Patch attached; if it is fine with you, I'll mark it "ready for =
committer".
>=20
> Yours,
> Laurenz Albe
> <v4-0001-Unclutter-CREATE-TABLE-synopsis.patch>

Overall the change looks good to me. I have only one comment about the =
naming of =E2=80=9Coversize_storage=E2=80=9D. Why not just =
=E2=80=9Cstorage_parameters=E2=80=9D or similar that sounds more =
straightforward?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/