Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: Control your disk usage in PG: Introduction to Disk Quota
 Extension
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <7025C3BF-C91E-44EB-AE45-121EC79DC1E4@yesql.se>
Date: Fri, 31 Jul 2020 21:35:18 +0200
Cc: David Steele <david@pgmasters.net>,
 Michael Paquier <michael@paquier.xyz>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Hubert Zhang <hzhang@pivotal.io>,
 Thomas Munro <thomas.munro@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 Robert Haas <robertmhaas@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Heikki Linnakangas <hlinnakangas@pivotal.io>
Content-Transfer-Encoding: quoted-printable
Message-Id: <63F817B8-66F5-4327-AF9C-CEBECC36BF90@yesql.se>
References: 
 <CAB0yre=mpb+8Ti9SokrXUZ7Hv2Hi1qDmQsP=d=dCmbh7buZ82w@mail.gmail.com>
 <20190925195435.GA21518@alvherre.pgsql>
 <CAL_NLp+6W68ynPg1xYu_HZgQgWb2m+WueB7FPEzUhLc=v+=3kw@mail.gmail.com>
 <20191201032011.GC2355@paquier.xyz>
 <CAL_NLpJLDJ6t0Uw=SVho=BT8MS=neCPAxvO+FYXNj_u2R11b2g@mail.gmail.com>
 <f861c5b4-4444-c071-2f3a-62d30b6d2f23@pgmasters.net>
 <CAL_NLpKWCE4tf93aS2DBe2Bs0Znst2TetVr9Jdj7FBGNqRaFyg@mail.gmail.com>
 <7025C3BF-C91E-44EB-AE45-121EC79DC1E4@yesql.se>
To: Haozhou Wang <hawang@pivotal.io>
Precedence: bulk

> On 1 Jul 2020, at 10:36, Daniel Gustafsson <daniel@yesql.se> wrote:
>=20
>> On 27 Mar 2020, at 11:22, Haozhou Wang <hawang@pivotal.io> wrote:
>=20
>> We rebased this patch with the newest master.
>=20
> This patch now fails to build according to Travis:
>=20
> smgr.c: In function =E2=80=98smgrtruncate=E2=80=99:
> smgr.c:578:47: error: passing argument 4 of =E2=80=98smgrtruncate_hook=E2=
=80=99 makes integer from pointer without a cast =
[-Werror=3Dint-conversion]
>   (*smgrtruncate_hook)(reln, forknum, nforks, nblocks);
>                                               ^
> smgr.c:578:47: note: expected =E2=80=98BlockNumber {aka unsigned =
int}=E2=80=99 but argument is of type =E2=80=98BlockNumber * {aka =
unsigned int *}=E2=80=99
>=20
>=20
> The warning is also present in the Windows build:
>=20
> src/backend/storage/smgr/smgr.c(578): warning C4047: 'function' : =
'BlockNumber' differs in levels of indirection from 'BlockNumber *' =
[C:\projects\postgresql\postgres.vcxproj]
> src/backend/storage/smgr/smgr.c(578): warning C4024: =
'smgrtruncate_hook' : different types for formal and actual parameter 4 =
[C:\projects\postgresql\postgres.vcxproj]
> 2 Warning(s)
>=20
> Marking the patch as Waiting for Author.=20

As the thread has stalled and the above compilation issue hasn't been
addressed, I'm marking this entry Returned with Feedback.  Feel free to =
open a
new entry when there is a fixed patch.

cheers ./daniel=