Feedback-ID: i131946ab:Fastmail
Message-ID: <63a898b5-dc09-1ec1-40ec-e9d09e8304e7@enterprisedb.com>
Date: Thu, 12 Jan 2023 18:00:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: drop postmaster symlink
Content-Language: en-US
To: Joe Conway <mail@joeconway.com>, Robert Haas <robertmhaas@gmail.com>,
 Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?=
 <devrim@gunduz.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ece84b69-8f94-8b88-925f-64207cb3a2f0@enterprisedb.com>
 <252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com>
 <6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org>
 <3705500.1669216069@sss.pgh.pa.us>
 <20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de>
 <CA+TgmoZdJ3TOBCnoz0x0zzfOtbOR12f1PHLQP8G1U3NEycUgRw@mail.gmail.com>
 <61846051-90b9-adb6-7627-08a374473a61@joeconway.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <61846051-90b9-adb6-7627-08a374473a61@joeconway.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/63a898b5-dc09-1ec1-40ec-e9d09e8304e7%40enterprisedb.com>
Precedence: bulk

On 23.11.22 21:32, Joe Conway wrote:
>> Yeah. Also, I don't think it's generally too hard to find the parent
>> process anyway, because at least on my system, the other ones end up
>> with ps display that looks like "postgres: logical replication
>> launcher" or whatever. The main process doesn't set the ps status
>> display, so that's the only one that shows a full path to the
>> executable in the ps status, which is how I usually spot it. That has
>> the advantage that it doesn't matter which name was used to launch it,
>> too.

I think it is a problem that one of the most widely used packagings of 
PostgreSQL uses techniques that are directly contradicting the 
PostgreSQL documentation and are also inconsistent with other widely 
used packagings.  Users might learn this "trick" but then can't reuse it 
elsewhere, and conversely those who come from other systems might not be 
able to reuse their scripts.  That is annoying.

> FWIW, the reason I took note of the postmaster symlink in the first 
> place a few years ago was because selinux treats execution of programs 
> from symlinks differently than from actual files.

This is another such case, where knowledge about selinux configuration 
cannot be transported between Linux distributions.

I almost feel that issues like this make a stronger case for removing 
the postmaster symlink than if it hadn't actually been in use, since the 
removal would serve to unify the landscape for the benefit of users.