Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljJND-0005u3-DC for pgsql-hackers@arkaria.postgresql.org; Wed, 19 May 2021 10:24:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ljJNB-0006E3-Kh for pgsql-hackers@arkaria.postgresql.org; Wed, 19 May 2021 10:24:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljJNB-0006Dv-Cs for pgsql-hackers@lists.postgresql.org; Wed, 19 May 2021 10:24:17 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljJN8-000652-KW for pgsql-hackers@postgresql.org; Wed, 19 May 2021 10:24:16 +0000 Received: from hnk.local (sp49-98-213-158.msd.spmode.ne.jp [49.98.213.158]) by oss.nttdata.com (Postfix) with ESMTPSA id A26C060785; Wed, 19 May 2021 19:24:09 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.2 at oss.nttdata.com Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing. To: Kyotaro Horiguchi Cc: dilipbalaut@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org References: <20210519.152529.1656496447023808157.horikyota.ntt@gmail.com> <25396c69-9f70-ca3e-5de3-f3a108ae2a26@oss.nttdata.com> <20210519.164352.1786666023204393975.horikyota.ntt@gmail.com> From: Fujii Masao Message-ID: <63ad1368-18e2-8900-8443-524bdfb1bef5@oss.nttdata.com> Date: Wed, 19 May 2021 19:24:09 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210519.164352.1786666023204393975.horikyota.ntt@gmail.com> Content-Type: multipart/mixed; boundary="------------E61FC671F50E478998AB5951" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------E61FC671F50E478998AB5951 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2021/05/19 16:43, Kyotaro Horiguchi wrote: > +1 for adding some tests for pg_wal_replay_pause() but the test seems > like checking only that pg_get_wal_replay_pause_state() returns the > expected state value. Don't we need to check that the recovery is > actually paused and that the promotion happens at expected LSN? Sounds good. Attached is the updated version of the patch. I added such checks into the test. BTW, while reading some recovery regression tests, I found that 013_crash_restart.pl has "use Time::HiRes qw(usleep)" but it seems not necessary. We can safely remove that? Patch attached. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------E61FC671F50E478998AB5951 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="recovery_pause_test_v2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="recovery_pause_test_v2.patch" ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDA1X3JlcGxheV9kZWxheS5wbCBi L3NyYy90ZXN0L3JlY292ZXJ5L3QvMDA1X3JlcGxheV9kZWxheS5wbAppbmRleCA3ZjE3N2Fm YWVkLi40OTZmYTQwZmUxIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzAwNV9y ZXBsYXlfZGVsYXkucGwKKysrIGIvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMDVfcmVwbGF5X2Rl bGF5LnBsCkBAIC0xLDEzICsxLDEzIEBACiAKICMgQ29weXJpZ2h0IChjKSAyMDIxLCBQb3N0 Z3JlU1FMIEdsb2JhbCBEZXZlbG9wbWVudCBHcm91cAogCi0jIENoZWNrcyBmb3IgcmVjb3Zl cnlfbWluX2FwcGx5X2RlbGF5CisjIENoZWNrcyBmb3IgcmVjb3ZlcnlfbWluX2FwcGx5X2Rl bGF5IGFuZCByZWNvdmVyeSBwYXVzZQogdXNlIHN0cmljdDsKIHVzZSB3YXJuaW5nczsKIAog dXNlIFBvc3RncmVzTm9kZTsKIHVzZSBUZXN0TGliOwotdXNlIFRlc3Q6Ok1vcmUgdGVzdHMg PT4gMTsKK3VzZSBUZXN0OjpNb3JlIHRlc3RzID0+IDM7CiAKICMgSW5pdGlhbGl6ZSBwcmlt YXJ5IG5vZGUKIG15ICRub2RlX3ByaW1hcnkgPSBnZXRfbmV3X25vZGUoJ3ByaW1hcnknKTsK QEAgLTU1LDMgKzU1LDU4IEBAICRub2RlX3N0YW5kYnktPnBvbGxfcXVlcnlfdW50aWwoJ3Bv c3RncmVzJywKICMgdGhlIGNvbmZpZ3VyZWQgYXBwbHkgZGVsYXkuCiBvayh0aW1lKCkgLSAk cHJpbWFyeV9pbnNlcnRfdGltZSA+PSAkZGVsYXksCiAJInN0YW5kYnkgYXBwbGllcyBXQUwg b25seSBhZnRlciByZXBsaWNhdGlvbiBkZWxheSIpOworCisKKyMgQ2hlY2sgdGhhdCByZWNv dmVyeSBjYW4gYmUgcGF1c2VkIG9yIHJlc3VtZWQgZXhwZWN0ZWRseS4KK215ICRub2RlX3N0 YW5kYnkyID0gZ2V0X25ld19ub2RlKCdzdGFuZGJ5MicpOworJG5vZGVfc3RhbmRieTItPmlu aXRfZnJvbV9iYWNrdXAoJG5vZGVfcHJpbWFyeSwgJGJhY2t1cF9uYW1lLAorCWhhc19zdHJl YW1pbmcgPT4gMSk7Ciskbm9kZV9zdGFuZGJ5Mi0+c3RhcnQ7CisKKyMgUmVjb3ZlcnkgaXMg bm90IHlldCBwYXVzZWQuCitpcygkbm9kZV9zdGFuZGJ5Mi0+c2FmZV9wc3FsKCdwb3N0Z3Jl cycsCisJIlNFTEVDVCBwZ19nZXRfd2FsX3JlcGxheV9wYXVzZV9zdGF0ZSgpIiksCisJJ25v dCBwYXVzZWQnLCAncGdfZ2V0X3dhbF9yZXBsYXlfcGF1c2Vfc3RhdGUoKSByZXBvcnRzIG5v dCBwYXVzZWQnKTsKKworIyBSZXF1ZXN0IHRvIHBhdXNlIHJlY292ZXJ5IGFuZCB3YWl0IHVu dGlsIGl0J3MgYWN0dWFsbHkgcGF1c2VkLgorJG5vZGVfc3RhbmRieTItPnNhZmVfcHNxbCgn cG9zdGdyZXMnLCAiU0VMRUNUIHBnX3dhbF9yZXBsYXlfcGF1c2UoKSIpOworJG5vZGVfcHJp bWFyeS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCisJIklOU0VSVCBJTlRPIHRhYl9pbnQgVkFM VUVTIChnZW5lcmF0ZV9zZXJpZXMoMjEsMzApKSIpOworJG5vZGVfc3RhbmRieTItPnBvbGxf cXVlcnlfdW50aWwoJ3Bvc3RncmVzJywKKwkiU0VMRUNUIHBnX2dldF93YWxfcmVwbGF5X3Bh dXNlX3N0YXRlKCkgPSAncGF1c2VkJyIpCisJb3IgZGllICJUaW1lZCBvdXQgd2hpbGUgd2Fp dGluZyBmb3IgcmVjb3ZlcnkgdG8gYmUgcGF1c2VkIjsKKworIyBFdmVuIGlmIG5ldyBXQUwg cmVjb3JkcyBhcmUgc3RyZWFtZWQgZnJvbSB0aGUgcHJpbWFyeSwKKyMgcmVjb3ZlcnkgaW4g dGhlIHBhdXNlZCBzdGF0ZSBkb2Vzbid0IHJlcGxheSB0aGVtLgorbXkgJHJlY2VpdmVfbHNu ID0gJG5vZGVfc3RhbmRieTItPnNhZmVfcHNxbCgncG9zdGdyZXMnLAorCSJTRUxFQ1QgcGdf bGFzdF93YWxfcmVjZWl2ZV9sc24oKSIpOworbXkgJHJlcGxheV9sc24gPSAkbm9kZV9zdGFu ZGJ5Mi0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCisJIlNFTEVDVCBwZ19sYXN0X3dhbF9yZXBs YXlfbHNuKCkiKTsKKyRub2RlX3ByaW1hcnktPnNhZmVfcHNxbCgncG9zdGdyZXMnLAorCSJJ TlNFUlQgSU5UTyB0YWJfaW50IFZBTFVFUyAoZ2VuZXJhdGVfc2VyaWVzKDMxLDQwKSkiKTsK KyRub2RlX3N0YW5kYnkyLT5wb2xsX3F1ZXJ5X3VudGlsKCdwb3N0Z3JlcycsCisJIlNFTEVD VCAnJHJlY2VpdmVfbHNuJzo6cGdfbHNuIDwgcGdfbGFzdF93YWxfcmVjZWl2ZV9sc24oKSIp CisJb3IgZGllICJUaW1lZCBvdXQgd2hpbGUgd2FpdGluZyBmb3IgbmV3IFdBTCB0byBiZSBz dHJlYW1lZCI7Citpcygkbm9kZV9zdGFuZGJ5Mi0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCisJ IlNFTEVDVCBwZ19sYXN0X3dhbF9yZXBsYXlfbHNuKCkiKSwKKwlxcSgkcmVwbGF5X2xzbiks ICdubyBXQUwgaXMgcmVwbGF5ZWQgaW4gdGhlIHBhdXNlZCBzdGF0ZScpOworCisjIFJlcXVl c3QgdG8gcmVzdW1lIHJlY292ZXJ5IGFuZCB3YWl0IHVudGlsIGl0J3MgYWN0dWFsbHkgcmVz dW1lZC4KKyRub2RlX3N0YW5kYnkyLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywgIlNFTEVDVCBw Z193YWxfcmVwbGF5X3Jlc3VtZSgpIik7Ciskbm9kZV9zdGFuZGJ5Mi0+cG9sbF9xdWVyeV91 bnRpbCgncG9zdGdyZXMnLAorCSJTRUxFQ1QgcGdfZ2V0X3dhbF9yZXBsYXlfcGF1c2Vfc3Rh dGUoKSA9ICdub3QgcGF1c2VkJyBBTkQgcGdfbGFzdF93YWxfcmVwbGF5X2xzbigpID4gJyRy ZXBsYXlfbHNuJzo6cGdfbHNuIikKKwlvciBkaWUgIlRpbWVkIG91dCB3aGlsZSB3YWl0aW5n IGZvciByZWNvdmVyeSB0byBiZSByZXN1bWVkIjsKKworIyBDaGVjayB0aGF0IHRoZSBwYXVz ZWQgc3RhdGUgZW5kcyBhbmQgcHJvbW90aW9uIGNvbnRpbnVlcyBpZiBhIHByb21vdGlvbgor IyBpcyB0cmlnZ2VyZWQgd2hpbGUgcmVjb3ZlcnkgaXMgcGF1c2VkLgorJG5vZGVfc3RhbmRi eTItPnNhZmVfcHNxbCgncG9zdGdyZXMnLCAiU0VMRUNUIHBnX3dhbF9yZXBsYXlfcGF1c2Uo KSIpOworJG5vZGVfcHJpbWFyeS0+c2FmZV9wc3FsKCdwb3N0Z3JlcycsCisJIklOU0VSVCBJ TlRPIHRhYl9pbnQgVkFMVUVTIChnZW5lcmF0ZV9zZXJpZXMoNDEsNTApKSIpOworJG5vZGVf c3RhbmRieTItPnBvbGxfcXVlcnlfdW50aWwoJ3Bvc3RncmVzJywKKwkiU0VMRUNUIHBnX2dl dF93YWxfcmVwbGF5X3BhdXNlX3N0YXRlKCkgPSAncGF1c2VkJyIpCisgIG9yIGRpZSAiVGlt ZWQgb3V0IHdoaWxlIHdhaXRpbmcgZm9yIHJlY292ZXJ5IHRvIGJlIHBhdXNlZCI7CisKKyRu b2RlX3N0YW5kYnkyLT5wcm9tb3RlOworJG5vZGVfc3RhbmRieTItPnBvbGxfcXVlcnlfdW50 aWwoJ3Bvc3RncmVzJywKKwkiU0VMRUNUIE5PVCBwZ19pc19pbl9yZWNvdmVyeSgpIikKKyAg b3IgZGllICJUaW1lZCBvdXQgd2hpbGUgd2FpdGluZyBmb3IgcHJvbW90aW9uIHRvIGZpbmlz aCI7Cg== --------------E61FC671F50E478998AB5951 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="remove_unnecessary_hires_usleep_v1.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="remove_unnecessary_hires_usleep_v1.patch" ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDEzX2NyYXNoX3Jlc3RhcnQucGwg Yi9zcmMvdGVzdC9yZWNvdmVyeS90LzAxM19jcmFzaF9yZXN0YXJ0LnBsCmluZGV4IDY2ZTQz ZmZiZTguLmUxYzM2YWJlOTcgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDEz X2NyYXNoX3Jlc3RhcnQucGwKKysrIGIvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMTNfY3Jhc2hf cmVzdGFydC5wbApAQCAtMTcsNyArMTcsNiBAQCB1c2UgUG9zdGdyZXNOb2RlOwogdXNlIFRl c3RMaWI7CiB1c2UgVGVzdDo6TW9yZTsKIHVzZSBDb25maWc7Ci11c2UgVGltZTo6SGlSZXMg cXcodXNsZWVwKTsKIAogcGxhbiB0ZXN0cyA9PiAxODsKIAo= --------------E61FC671F50E478998AB5951--