Message-ID: <63f3be31-d7c4-0ff4-e5f4-7368863da1bc@dunslane.net>
Date: Thu, 13 Jan 2022 15:27:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: Adding CI to our tree
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Daniel Gustafsson <daniel@yesql.se>
References: <20211001222752.wrz7erzh4cajvgp6@alap3.anarazel.de>
 <20211231014652.kgrdk2wytiallix3@alap3.anarazel.de>
 <20220109191649.GL14051@telsasoft.com>
 <20220109195744.mjoue2pr6xtnsquw@alap3.anarazel.de>
 <20220110220748.GS14051@telsasoft.com>
 <20220113185527.kgzmxutkydkyktuq@alap3.anarazel.de>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <20220113185527.kgzmxutkydkyktuq@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/63f3be31-d7c4-0ff4-e5f4-7368863da1bc%40dunslane.net>
Precedence: bulk


On 1/13/22 13:55, Andres Freund wrote:
>> It needs to avoid running on the buildfarm, right ?
> I guess so. It currently appears to have its own logic for finding contrib
> (and other) tap tests:
>
>         foreach my $testdir (glob("$pgsql/contrib/*"))
>         {
>                 next unless -d "$testdir/t";
>                 my $testname = basename($testdir);
>                 next unless step_wanted("contrib-$testname");
>                 print time_str(), "running contrib test $testname ...\n" if $verbose;
>                 run_tap_test("$testdir", "contrib-$testname", undef);
>         }
>
> but does run vcregress contribcheck, modulescheck.
>
>
> Andrew, do you see a better way than what Justin is proposing here?
>

I can probably adjust to whatever we decide to do. But I think we're
really just tinkering at the edges here. What I think we really need is
the moral equivalent of `make check-world` in one invocation of
vcregress.pl.

While we're on the subject of vcregress.pl, there's this recent
discussion, which is on my list of things to return to:
<https://www.postgresql.org/message-id/46c40cc7-db28-b684-379d-43b34daa5ffa%40dunslane.net>


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com