From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Devrim =?iso-8859-1?B?R/xuZPx6?= <devrim@gunduz.org>,
        pgsql-hackers@lists.postgresql.org,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: head fails to build on SLES 12 (wal_compression=zstd)
In-reply-to: <20220331153740.GP28503@telsasoft.com>
References: <efbd94cd1102f99fd1300e44905ee4a994ee2ef6.camel@gunduz.org>
 <551019.1648736791@sss.pgh.pa.us>
 <f62f4d5e06faa33d47db77a3ea5349480d405043.camel@gunduz.org>
 <20220331153740.GP28503@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Thu, 31 Mar 2022 10:37:40 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <641009.1648741480.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 31 Mar 2022 11:44:40 -0400
Message-ID: <641010.1648741480@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/641010.1648741480%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> Possible responses look like:
>  - Use 0 which also means "default" (need to verify that works across ve=
rsions);
>  - Or #ifndef ZSTD_CLEVEL_DEFAULT #define ZSTD_CLEVEL_DEFAULT 3;
>  - Add a test for a minimum zstd version v1.3.7.  This may be a good ide=
a for
>    v15 in any case, since we're using a few different APIs (at least
>    ZSTD_compress and ZSTD_compressStream2 and execve(zstd)).

In view of 51c0d186d ("Allow parallel zstd compression"), I agree
that some clarity about the minimum supported version of zstd
seems essential.  I don't want to be dealing with threading bugs
in ancient zstd versions.  However, why do you suggest 1.3.7 in
particular?

			regards, tom lane