From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: bossartn@amazon.com, Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        michael@paquier.xyz, sulamul@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: inefficient loop in StandbyReleaseLockList()
In-reply-to: <20211106224648.wcmavq6ngv43ysb7@alap3.anarazel.de>
References: <C84534A6-2E66-47FF-B193-EBB566544D49@amazon.com>
 <1311319.1635804078@sss.pgh.pa.us>
 <20211102.114313.713245704579079227.horikyota.ntt@gmail.com>
 <1376384.1635862908@sss.pgh.pa.us> <1512317.1635867355@sss.pgh.pa.us>
 <20211104221248.pgo4h6wvnjl6uvkb@alap3.anarazel.de>
 <364794.1636071716@sss.pgh.pa.us> <588672.1636221972@sss.pgh.pa.us>
 <20211106222251.msmjshfhvcvy3lpd@alap3.anarazel.de>
 <613307.1636237974@sss.pgh.pa.us>
 <20211106224648.wcmavq6ngv43ysb7@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 06 Nov 2021 15:46:48 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <641259.1636240411.1@sss.pgh.pa.us>
Date: Sat, 06 Nov 2021 19:13:31 -0400
Message-ID: <641260.1636240411@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/641260.1636240411%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2021-11-06 18:32:54 -0400, Tom Lane wrote:
>> Good point.  The note at list_delete_last that it's O(1) isn't really
>> on point --- instead, the text for list_delete_first should be like
>> 
>> + * Note that this takes time proportional to the length of the list,
>> + * since the remaining entries must be moved.  Consider reversing the
>> + * list order so that you can use list_delete_last() instead.  However,
>> + * if that causes you to replace lappend() with lcons(), you haven't
>> + * improved matters.

> LGTM

Done that way, then.

			regards, tom lane