From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Printing window function OVER clauses in EXPLAIN
In-reply-to: 
 <CAApHDvpT8W3svBF_4u-0wJ5UMU1weL+aZD8jwbJLBB3zkY5_8w@mail.gmail.com>
References: <202503091412.mzlgmzmmzwim@alvherre.pgsql>
 <279724.1741535141@sss.pgh.pa.us> <616793.1741558789@sss.pgh.pa.us>
 <CAApHDvpT8W3svBF_4u-0wJ5UMU1weL+aZD8jwbJLBB3zkY5_8w@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Mon, 10 Mar 2025 13:14:49 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <641585.1741569208.1@sss.pgh.pa.us>
Date: Sun, 09 Mar 2025 21:13:28 -0400
Message-ID: <641586.1741569208@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/641586.1741569208%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> What are your thoughts on being a bit more brief with the naming and
> just prefix with "w" instead of "window"? Looking at window.out, I see
> that the EXPLAIN output does become quite a bit wider than before. I
> favour the idea of saving a bit of space.  There is an example in
> src/sgml/advanced.sgml that has "OVER w", so it does not seem overly
> strange to me to name them "w1", "w2", etc.

OK by me, any objections elsewhere?

>> * In passing, I editorialized on the order in which the Run Condition
>> annotation comes out:

> I did it that way because "Rows Removed by Filter" is a property of
> "Filter", so it makes sense to me for those to be together. It doesn't
> make sense to me to put something unrelated between them.

Hmm, OK.  Do you think it could be sensible to put Run Condition
before Filter, then?  On the same grounds of "keeping related
things together", it could be argued that Run Condition is
related to the Window property.  Also, the Run Condition acts
before the Filter does, if I've got my head screwed on straight.

			regards, tom lane