From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Should contrib modules install .h files?
In-reply-to: <878t6to8j9.fsf@news-spur.riddles.org.uk>
References: <87y3euomjh.fsf@news-spur.riddles.org.uk>
 <ee05ea4c-3d5b-0ec6-8daa-3ec66f021076@2ndquadrant.com>
 <87tvpinfr4.fsf@news-spur.riddles.org.uk> <63444.1530537990@sss.pgh.pa.us>
 <87lgatohzp.fsf@news-spur.riddles.org.uk> <63655.1530540982@sss.pgh.pa.us>
 <87h8lhoevw.fsf@news-spur.riddles.org.uk> <63819.1530544945@sss.pgh.pa.us>
 <878t6to8j9.fsf@news-spur.riddles.org.uk>
Comments: In-reply-to Andrew Gierth <andrew@tao11.riddles.org.uk>
	message dated "Mon, 02 Jul 2018 19:23:25 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <64173.1530564363.1@sss.pgh.pa.us>
Date: Mon, 02 Jul 2018 16:46:04 -0400
Message-ID: <64174.1530564364@sss.pgh.pa.us>
Precedence: bulk

Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> Two questions arise:

> 1) include/server has a lot of files and subdirs, so using
>    include/server/$(MODULE)/ looks likely to be error-prone. So it
>    should be something like include/server/contrib/$(MODULE)/ or
>    include/server/extension/$(MODULE)/. Which one, or should it use
>    $(MODULEDIR) to choose between the two the way that DATA and DOCS do?
>    Or something else?

Might as well follow the MODULEDIR precedent (though I'm not wedded
to that if somebody has an argument for something else).

> 2) Specifying HEADERS_blah for some name "blah" that's not listed in
>    MODULES or MODULE_big should do what:
>   a) install into blah/ anyway
>   b) be ignored with a warning
>   c) be silently ignored
>   d) be an error

I'd definitely vote for "error".  Likewise if any .h file listed in
the macro doesn't exist.

			regards, tom lane