Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iTUCE-0004NG-F0 for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Nov 2019 17:06:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iTUCB-0001jz-Qj for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Nov 2019 17:06:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iTUCB-0001jr-7J for pgsql-hackers@lists.postgresql.org; Sat, 09 Nov 2019 17:06:43 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iTUC3-0003Ql-NF for pgsql-hackers@lists.postgresql.org; Sat, 09 Nov 2019 17:06:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xA9H6XPW006438 for ; Sat, 9 Nov 2019 12:06:33 -0500 From: Tom Lane To: pgsql-hackers@lists.postgresql.org Subject: int64-timestamp-dependent test vs. --disable-integer-timestamps MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6436.1573319193.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 09 Nov 2019 12:06:33 -0500 Message-ID: <6437.1573319193@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Commits a7145f6bc et al. added a test to verify integer overflow detection in interval_mul. The buildfarm has now reminded me that you're not going to get integer overflow if timestamps ain't integers, cf https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmandrill&dt=3D20= 19-11-08%2019%3A42%3A32 I think the most expedient answer is just to remove that test case in the pre-v10 branches. It's already served its purpose by showing that the rest of the buildfarm is OK. I'd work harder on this if --disable-integer-timestamps were still a live option, but it's hard to justify any complicated solution. regards, tom lane [ wanders away wondering if we should have more than one critter testing --disable-integer-timestamps ]