Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oo2wV-0007Fn-Dq
	for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Oct 2022 13:29:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oo2wU-00014i-C7
	for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Oct 2022 13:29:06 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oo2wU-00014Y-2T
	for pgsql-hackers@lists.postgresql.org; Thu, 27 Oct 2022 13:29:06 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oo2wR-0001J1-WB
	for pgsql-hackers@lists.postgresql.org; Thu, 27 Oct 2022 13:29:05 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 29RDT20V644165;
	Thu, 27 Oct 2022 09:29:02 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zhang Mingli <zmlpostgres@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Reducing duplicativeness of EquivalenceClass-derived clauses
In-reply-to: <2faecd55-6786-471c-84ac-36aa7149abee@Spark>
References: <78062.1666735746@sss.pgh.pa.us>
 <2faecd55-6786-471c-84ac-36aa7149abee@Spark>
Comments: In-reply-to Zhang Mingli <zmlpostgres@gmail.com>
	message dated "Thu, 27 Oct 2022 21:21:17 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <644163.1666877342.1@sss.pgh.pa.us>
Date: Thu, 27 Oct 2022 09:29:02 -0400
Message-ID: <644164.1666877342@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/644164.1666877342%40sss.pgh.pa.us>
Precedence: bulk

Zhang Mingli <zmlpostgres@gmail.com> writes:
> How about combine ec->ec_sources and ec->derives as one list for less codes?

Keeping them separate is required for the broken-EC code paths.
Even if it weren't, I wouldn't merge them just to save a couple
of lines of code --- I think it's useful to be able to tell which
clauses the EC started from.

			regards, tom lane