Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltW9E-0001AD-1y for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Jun 2021 14:04:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ltW9D-0008W4-0v for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Jun 2021 14:04:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltW9C-0008Vw-P4 for pgsql-hackers@lists.postgresql.org; Wed, 16 Jun 2021 14:04:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltW99-0000lN-GD for pgsql-hackers@lists.postgresql.org; Wed, 16 Jun 2021 14:04:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15GE3qO0645785; Wed, 16 Jun 2021 10:03:52 -0400 From: Tom Lane To: Noah Misch cc: Andres Freund , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Subject: Re: Improving isolationtester's data output In-reply-to: <20210616034323.GA965392@rfd.leadboat.com> References: <202106152320.xfiprkh4sp5c@alvherre.pgsql> <583674.1623799585@sss.pgh.pa.us> <20210616013115.2otscs7rwictsolv@alap3.anarazel.de> <592938.1623807811@sss.pgh.pa.us> <20210616034323.GA965392@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Tue, 15 Jun 2021 20:43:23 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <645783.1623852232.1@sss.pgh.pa.us> Date: Wed, 16 Jun 2021 10:03:52 -0400 Message-ID: <645784.1623852232@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > I'm +1 for back-patching this class of change. I've wasted time adapting a > back-patch's test case to account for non-back-patched test infrastructure > changes. Every back-patch of test infrastructure has been a strict win from > my perspective. Hearing few objections, I'll plan on back-patching. I'm thinking that the best thing to do is apply these changes after beta2 wraps, but before we branch v14. Waiting till after the branch would just create duplicate work. BTW, as long as we're thinking of back-patching nontrivial specfile changes, I have another modest proposal. What do people think of removing the requirement for step/session names to be double-quoted, and instead letting them work like SQL identifiers? A quick grep shows that practically all the existing names are plain identifiers, so we could just drop their quotes for a useful notational savings. While I haven't actually tried yet, I doubt it'd be hard to adopt scan.l's identifier rules into specscanner.l. (Probably wouldn't bother with auto case-folding, though.) regards, tom lane