Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVYBD-000Wz7-LD for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Aug 2023 14:04:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qVYBB-004nl6-Ap for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Aug 2023 14:04:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVYBA-004nkV-Aj for pgsql-hackers@lists.postgresql.org; Mon, 14 Aug 2023 14:04:21 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVYB7-0006Wy-7P for pgsql-hackers@postgresql.org; Mon, 14 Aug 2023 14:04:19 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5346032007BE; Mon, 14 Aug 2023 10:04:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 14 Aug 2023 10:04:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1692021851; x=1692108251; bh=lIwjTzVHbn7tgYQUKe9dngb3h oWcLYMd6kFSihp7aLY=; b=SHwoF1Z2m04B6/Wi77QZDcUB0IxZYXUHwD/MYIHBt mglQGH7SNvp61YiOR2qIv3KST2krs9fm1+gNQLBDyGlsEFq4FBGLwc6ZgD8Z2nkt zE9WOdWCkNumI62Ftq+9uyTvsvoOrSBXrobMvsla+1Ie3AB4jjRBmxldez2XtUAE A4eVURDRsLAc+OP3P1yIFzcN8U5iQxYKEbmLXrLLOtJvVmEIUqfXzkh1tD5enUeB e1ULR5s/A0uuLDpzNuga3/+P6TF90SqDx1EYRgMLr3RMTuwPUigp//djWFX8FiS+ 7NdpWQWJ+iAv2+Tf0sD2dyK3hRmvmnBzbkRVpGRTbYWkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692021851; x=1692108251; bh=lIwjTzVHbn7tgYQUKe9dngb3hoWcLYMd6kF Sihp7aLY=; b=cShmNwo+QL2GPh9iZ53Z2eOUc910ZMolzBWirFxify7DlhbTAJp 1YkisgWbo7Ro+f25/8N2MNBOJtawUnP6pelBpLE7B3RF8xoTYfk9k/55iy+i3BZX hBQNzpxZaJR0TxoeNpiULfNkhiVMosSrkt14+v5i2apFiNmi095/PoVtLQxFSp+Y zNxeaarFgApuLBwgvdkZ/GLOZO169CG2zLxdMYYpIwiAXgbRZA/IYX6cggyEfcNt UmjELL4OhngKy2G4sdc+Ml+IlNEKay0nF/Pak0ttGKYPA1nRWHedBw0Z4E+ipjkI nCMQ+IykrLARtkS7/33xYZXFxj1fvgD34Jw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtgedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepheeiuefhleelfeeikeehkefgkeeggfevheeuvdejveet tdegleekffffieekuedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Aug 2023 10:04:06 -0400 (EDT) Message-ID: <645add52-2ed3-970d-c9e4-a1294669fb57@eisentraut.org> Date: Mon, 14 Aug 2023 16:04:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US To: Andres Freund , Andrew Dunstan Cc: Tom Lane , Peter Geoghegan , Jelte Fennema , Michael Paquier , "shiy.fnst@fujitsu.com" , Robert Haas , Justin Pryzby , Noah Misch , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut References: <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de> <338202.1691793002@sss.pgh.pa.us> <342032.1691794926@sss.pgh.pa.us> <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net> <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12.08.23 23:14, Andres Freund wrote: > It's a somewhat annoying task though, find all the typedefs, add them to the > right place in the file (we have an out of order entry right now). I think a > script that*adds* (but doesn't remove) local typedefs would make this less > painful. I was puzzled once that there does not appear to be such a script available. Whatever the buildfarm does (before it merges it all together) should be available locally. Then the workflow could be type type type compile update typedefs pgindent commit