Message-ID: <646aa41b-9810-442e-9a5a-69a5604190d4@gmail.com>
Date: Mon, 24 Nov 2025 19:46:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: get rid of Pointer type, mostly
To: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <4154950a-47ae-4223-bd01-1235cc50e933@eisentraut.org>
 <955002.1764000569@sss.pgh.pa.us>
 <CA+Tgmobo9ZMC0h1Z1Te9whf7q3LN7wUkzFLyuxfMZ4dyTNqKnw@mail.gmail.com>
 <957744.1764002037@sss.pgh.pa.us>
 <CA+TgmobhKe5WJybZ0EGQ85Qkxr-KLx4uW2_hFqt0iPbYq-af7Q@mail.gmail.com>
 <970261.1764008763@sss.pgh.pa.us>
Content-Language: en-US
From: David Geier <geidav.pg@gmail.com>
In-Reply-To: <970261.1764008763@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/646aa41b-9810-442e-9a5a-69a5604190d4%40gmail.com>
Precedence: bulk

I'm in big favor of this change. Such types just cover up what's really
going on and make reading the code more difficult than needed,
especially for people new to the code base.

On 24.11.2025 19:26, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:

> I can follow the argument that using the native type "void *" is
> better, since every C programmer must know that already.  But you
> cannot argue for this patch on that ground unless Pointer goes away
> entirely.  I don't understand leaving it in place for GIN.  It's
> not like GIN indexes are some hoary backwater that nobody pays
> attention to.

+1

The GIN code makes use of pointer but src/backend/access/gin only has 29
occurrences. If you like I can help out fixing up the GIN code and share
a page here. Let me know.

--
David Geier