public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jeff Davis <[email protected]>
To: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: allowing extensions to control planner behavior
Date: Wed, 28 Aug 2024 16:15:51 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoY4yBRawLY-u0GM6aW7f0N4W8RU8WsZRb5+qhpWWfmZcQ@mail.gmail.com>
References: <CA+TgmoZY+baV-T-5ifDn6P=L=aV-VkVBrPmi0TQkcEq-5Finww@mail.gmail.com>
	<[email protected]>
	<CA+TgmoY4yBRawLY-u0GM6aW7f0N4W8RU8WsZRb5+qhpWWfmZcQ@mail.gmail.com>

On Wed, 2024-08-28 at 16:35 -0400, Robert Haas wrote:
> On Wed, Aug 28, 2024 at 4:29 PM Jeff Davis <[email protected]> wrote:
> > Preserving a path for the right amount of time seems like the
> > primary
> > challenge for most of the use cases you raised (removing paths is
> > easier than resurrecting one that was pruned too early). If we try
> > to
> > keep a path around, that implies that we need to keep parent paths
> > around too, which leads to an explosion if we aren't careful.
> > 
> > But we already solved all of that for pathkeys. We keep the paths
> > around if there's a reason to (a useful pathkey) and there's not
> > some
> > other cheaper path that also satisfies the same reason.
> 
> But we've already solved it for this case, too. This is exactly what
> incrementing disabled_nodes does.

Hints are often described as something positive: use this index, use a
hash join here, etc. Trying to force a positive thing by adding
negative attributes to everything else is awkward. We've all had the
experience where we disable one plan type hoping for a good plan, and
we end up getting a different crazy plan that we didn't expect, and
need to disable a few more plan types.

Beyond awkwardness, one case where it matters is the interaction
between an extension that provides hints and an extension that offers a
CustomScan. How is the hints extension supposed to disable a path it
doesn't know about?

Regards,
	Jeff Davis

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: allowing extensions to control planner behavior
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox