From: Tom Lane <tgl@sss.pgh.pa.us>
To: Hannu Krosing <hannuk@google.com>
cc: Peter Eisentraut <peter@eisentraut.org>,
        "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: What is a typical precision of gettimeofday()?
In-reply-to: <CAMT0RQSdKQra6QC4b+eAynpqZ0SYdHDfGBBE7hty33OD9jx7Jg@mail.gmail.com>
References: <be0339cc-1ae1-4892-9445-8e6d8995a44d@eisentraut.org> <47AEACEE-E5CC-40E4-8611-01F3A465AF16@yandex-team.ru> <9e7b21e7-4c63-4299-87f4-780a0699a7d8@eisentraut.org> <130996.1718814994@sss.pgh.pa.us> <CAMT0RQSdKQra6QC4b+eAynpqZ0SYdHDfGBBE7hty33OD9jx7Jg@mail.gmail.com>
Comments: In-reply-to Hannu Krosing <hannuk@google.com>
	message dated "Thu, 20 Jun 2024 12:41:54 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <647659.1719003075.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 21 Jun 2024 16:51:15 -0400
Message-ID: <647660.1719003075@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/647660.1719003075%40sss.pgh.pa.us>
Precedence: bulk

Hannu Krosing <hannuk@google.com> writes:
> This is my current patch which also adds running % and optionally uses
> faster way to count leading zeros, though I did not  see a change from
> that.

I've not read the patch yet, but I did create a CF entry [1]
to get some CI cycles on this.  The cfbot complains [2] about

[19:24:31.951] pg_test_timing.c: In function =E2=80=98output=E2=80=99:
[19:24:31.951] pg_test_timing.c:229:11: error: format =E2=80=98%ld=E2=80=99=
 expects argument of type =E2=80=98long int=E2=80=99, but argument 3 has t=
ype =E2=80=98int64=E2=80=99 {aka =E2=80=98long long int=E2=80=99} [-Werror=
=3Dformat=3D]
[19:24:31.951]   229 |    printf("%*ld    %*.4f  %*.4f %*lld\n",
[19:24:31.951]       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[19:24:31.951]   230 |       Max(8, len1), i,
[19:24:31.951]       |                     ~
[19:24:31.951]       |                     |
[19:24:31.951]       |                     int64 {aka long long int}

which seems a bit confused, but anyway you cannot assume that int64 is
a match for "%ld", or "%lld" either.  What we generally do for this
elsewhere is to explicitly cast printf arguments to long long int.

Also there's this on Windows:

[19:23:48.231] ../src/bin/pg_test_timing/pg_test_timing.c(162): warning C4=
067: unexpected tokens following preprocessor directive - expected a newli=
ne

			regards, tom lane

[1] https://commitfest.postgresql.org/48/5066/
[2] http://cfbot.cputube.org/highlights/all.html#5066