Message-ID: <64a00122-26f3-678e-73a8-4bbd69de831d@dunslane.net>
Date: Wed, 17 Nov 2021 15:26:41 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: Non-superuser subscription owners
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>
References: <9DFC88D3-1300-4DE8-ACBC-4CEF84399A53@enterprisedb.com>
 <c1c334a2-5d85-687f-f0dc-0ac8c422ca1a@dunslane.net>
 <CD02D159-7260-4247-888F-2CFA7AD3798D@enterprisedb.com>
 <6BB4451E-7B1B-474C-BD1F-DB7531E720C6@enterprisedb.com>
 <d8ab69fd-e46e-8b20-22f3-37b6b6a47875@dunslane.net>
In-Reply-To: <d8ab69fd-e46e-8b20-22f3-37b6b6a47875@dunslane.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/64a00122-26f3-678e-73a8-4bbd69de831d%40dunslane.net>
Precedence: bulk


On 11/16/21 15:06, Andrew Dunstan wrote:
> On 11/3/21 15:50, Mark Dilger wrote:
>>> On Nov 1, 2021, at 10:58 AM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>>>
>>> ALTER SUBSCRIPTION..[ENABLE | DISABLE] do not synchronously start or stop subscription workers.  The ALTER command updates the catalog's subenabled field, but workers only lazily respond to that.  Disabling and enabling the subscription as part of the OWNER TO would not reliably accomplish anything.
>> I have rethought my prior analysis.  The problem in the previous patch was that the subscription apply workers did not check for a change in ownership the way they checked for other changes, instead only picking up the new ownership information when the worker restarted for some other reason.  This next patch set fixes that.  The application of a change record may continue under the old ownership permissions when a concurrent command changes the ownership of the subscription, but the worker will pick up the new permissions before applying the next record.  I think that is consistent enough with reasonable expectations.
>>
>> The first two patches are virtually unchanged.  The third updates the behavior of the apply workers, and updates the documentation to match.
>
> I'm generally happier about this than the previous patch set. With the
> exception of some slight documentation modifications I think it's
> basically committable. There doesn't seem to be a CF item for it but I'm
> inclined to commit it in a couple of days time.
>
>

Given there is some debate about the patch set I will hold off any
action for the time being.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com